[4.0]namespace administrator components com_joomlaupdate #21057
Conversation
brianteeman
requested review from
mbabker,
rdeutz,
wilsonge and
zero-24
as code owners
Why? Given that drone fails on something that is not related to this changes here anyway? |
|
|
||
| /* | ||
| * Check the PHP Version. It is already checked in JUpdate. | ||
| * Check the PHP Version. It is already checked in Update. |
There was a problem hiding this comment.
This result into a useless comment can we convert this please to
Check the PHP Version. It is already checked in the Update prozess
| define('_JEXEC', 1); | ||
| } | ||
|
|
||
| use Joomla\CMS\Language\Text; |
There was a problem hiding this comment.
This is 3rd Party Code. I'm not sure if we really should touch this.
There was a problem hiding this comment.
If we do we should also fix JFile to File but for me I'm not sure if that overrides apply anyway. (given that we now use namespaced versions of that code)
There was a problem hiding this comment.
it is not 3rd party code.
There was a problem hiding this comment.
My point about the overrides etc still stands even when there is a Joomla header in that file.
There was a problem hiding this comment.
This file is our hook point into the restore.php file. It is not third party.
|
|
||
| HTMLHelper::_('behavior.keepalive'); | ||
|
|
||
| $twofactormethods = \Joomla\CMS\Helper\AuthenticationHelper::getTwoFactorMethods(); |
There was a problem hiding this comment.
Should't this be imported by use also?
|
|
||
| HTMLHelper::_('behavior.keepalive'); | ||
|
|
||
| $twofactormethods = \Joomla\CMS\Helper\AuthenticationHelper::getTwoFactorMethods(); |
There was a problem hiding this comment.
Same here. Should be imported by use.
There was a problem hiding this comment.
should it>? you dont seem sure
There was a problem hiding this comment.
Yes please import it using a user and than use the namespaced version
|
Please add to the following test cases: Test case 1
Test case 2
|
| use Joomla\CMS\Router\Route; | ||
| use Joomla\CMS\Factory; | ||
| use Joomla\CMS\HTML\HTMLHelper; | ||
| use Joomla\CMS\Helper\\AuthenticationHelper; |
| use Joomla\CMS\User\UserHelper; | ||
| use Joomla\CMS\Client\ClientHelper; | ||
| use Joomla\CMS\Client\FtpClient; | ||
| use Joomla\CMS\Fileystem\File; |
| use Joomla\CMS\Response\JsonResponse; | ||
| use Joomla\CMS\Session\Session; | ||
| use Joomla\CMS\Client\ClientHelper; | ||
| use Joomla\CMS\Fileystem\File; |
|
Thanks! |
|
thanks |
6 participants
continuing the work to namespace joomla4 one admin component at a time.
please wait for drone to successfully complete before reviewing.