Add test cases for JDate constructor demonstrating broken timezone handling #15642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clearly the test fails which is the intended behaviour right now so this is all good |
|
Closed in favor of bug fixing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With 3.7, the internals of
JDateare now terribly broken. The attempt to handle the PHP 7.1 B/C break of supporting microseconds has also caused internal damage to the timezone handling of the system. This PR demonstrates the broken timezone handling.This is obviously not a complete PR to address the bug, simply one that should be used to ensure our issue is fixed. Whether this commit is combined into a final PR or merged separately is up to whomever acts on this.
Expected result
Tests pass
Actual result
Tests fail
Additional Resources
https://twitter.com/mbabker/status/857568147771187201