Skip to content

Various changes in libraries/cms #13238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 9, 2017
Merged

Various changes in libraries/cms #13238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1f14f22
Use modern day type casting
frankmayer Dec 15, 2016
31d8b4a
Simplify ternary operation
frankmayer Dec 15, 2016
506dbb8
Merge unset() calls
frankmayer Dec 15, 2016
10336bc
CS-Fix
frankmayer Dec 15, 2016
0e9defd
Merge branch 'staging' into various-changes-in-libraries-cms
frankmayer Apr 26, 2017
afbfc7e
Some more cases of unneeded parentheses and one ternary
frankmayer Apr 26, 2017
1aeca60
Some more cases of unneeded parentheses and fix of wrong implementati…
frankmayer Apr 26, 2017
c6c2377
One more thing...
frankmayer Apr 26, 2017
372e0d4
Merge branch 'staging' into various-changes-in-libraries-cms
rdeutz May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/cms/html/behavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ public static function tooltip($selector = '.hasTip', $params = array())
$opt['showDelay'] = (isset($params['showDelay'])) ? (int) $params['showDelay'] : null;
$opt['hideDelay'] = (isset($params['hideDelay'])) ? (int) $params['hideDelay'] : null;
$opt['className'] = (isset($params['className'])) ? $params['className'] : null;
$opt['fixed'] = (isset($params['fixed']) && ($params['fixed'])) ? true : false;
$opt['fixed'] = (isset($params['fixed']) && ($params['fixed']));
Copy link
Contributor

@Quy Quy Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove parentheses in ($params['fixed']). Also the outside parentheses can be removed in this line and the other lines too.

Copy link
Contributor Author

@frankmayer frankmayer Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed. Thanks. Have found one or two other improvements as well. Commit follows.

Copy link
Contributor Author

@frankmayer frankmayer Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out, some of the other improvements, were already in other PR's which have not been merged yet. It would be good to get the other improvements merged, too.

$opt['onShow'] = (isset($params['onShow'])) ? '\\' . $params['onShow'] : null;
$opt['onHide'] = (isset($params['onHide'])) ? '\\' . $params['onHide'] : null;

Expand Down
2 changes: 1 addition & 1 deletion libraries/cms/html/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ public static function startAccordion($selector = 'myAccordian', $params = array

// Setup options object
$opt['parent'] = isset($params['parent']) ? ($params['parent'] == true ? '#' . $selector : $params['parent']) : false;
$opt['toggle'] = isset($params['toggle']) ? (boolean) $params['toggle'] : ($opt['parent'] === false || isset($params['active']) ? false : true);
$opt['toggle'] = isset($params['toggle']) ? (boolean) $params['toggle'] : !($opt['parent'] === false || isset($params['active']));
$onShow = isset($params['onShow']) ? (string) $params['onShow'] : null;
$onShown = isset($params['onShown']) ? (string) $params['onShown'] : null;
$onHide = isset($params['onHide']) ? (string) $params['onHide'] : null;
Expand Down
2 changes: 1 addition & 1 deletion libraries/cms/html/tabs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ protected static function loadBehavior($group, $params = array())
$opt['descriptionSelector'] = "dd.tabs";

// When use storage is set and value is false - By default we allow to use storage
$opt['useStorage'] = (isset($params['useCookie']) && !$params['useCookie']) ? false : true;
$opt['useStorage'] = !(isset($params['useCookie']) && !$params['useCookie']);

$options = JHtml::getJSObject($opt);

Expand Down