Skip to content

Conversation

@roland-d
Copy link
Contributor

@roland-d roland-d commented May 8, 2016

Summary of Changes

This change does a few things:

  • Split the URL/Folder installation plugin into two separate plugins
  • Removed obsolete files
  • Removed obsolete code
  • Cleanup other issues (thank you @andrepereiradasilva taken also from New Installer plugins bugs #10296)
  • Added a message if no plugin is enabled
  • Moved the language strings to the plugin language files

Testing Instructions for a clean installation

  1. Download the zip file from this pull request containing the complete Joomla installation
  2. Do a clean installation
  3. Check the tabs are still under Manage -> Install

Testing Instructions for an update

  1. Install Joomla 3.5.1
  2. Download the zip file from this pull request containing the complete Joomla installation
  3. Setup a local update server
  4. Update the 3.5.1 to 3.6.0 using the local update server
  5. Check the tabs are still under Manage -> Install

Testing Instructions for both

  1. Disable all installer plugins in Plugin Manager
  2. Go to Manage -> Install and check there is a message saying there are no plugins enabled
  3. Check the link in the message works

roland-d added 6 commits May 8, 2016 08:22
…leanup-installer-plugins

* 'staging' of https://github.com/joomla/joomla-cms:
  Adding new plugin ini files to the install.xml (joomla#10302)
  Database connection problems on CLI
…leanup-installer-plugins

* 'staging' of https://github.com/joomla/joomla-cms:
  Smart Search: utf8_strpos: Offset must be an integer (joomla#10303)
  Removed an redundant else clause from JFeedParser::processElement (joomla#7961)
  CLEANING-JDataSet (joomla#7947)
  CLEANING-JAdapter (joomla#6679)
  Same  treatment as JArchiveBzip2 and JArchiveGzip (joomla#6515)
  Cleaning up JArchiveBzip2 (joomla#6495)
  Removed the nested conditional switch construct (joomla#6338)
  add edit tooltip to modules (joomla#10295)
  New installer plugins: remove the dot in the plugin name and other language review (joomla#10299)
…leanup-installer-plugins

* 'staging' of https://github.com/joomla/joomla-cms:
  Add missing com_finder to com_admin script php (joomla#10300)
  Add missing slash
  Removed redundant else statemetn from JFormHelper::loadType (joomla#7979)
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 8, 2016
@roland-d roland-d added this to the Joomla 3.6.0 milestone May 8, 2016
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.6.0 milestone May 8, 2016
DELETE FROM "#__extensions" WHERE "type" = "library" AND "element" = "simplepie";
INSERT INTO `#__extensions` (`extension_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `system_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES
(455, 'plg_installer_packageinstaller', 'plugin', 'packageinstaller', 'installer', 0, 1, 1, 1, '', '', '', '', 0, '0000-00-00 00:00:00', 1, 0),
(456, 'plg_installer_folderinstaller', 'plugin', 'folderinstaller', 'installer', 0, 1, 1, 1, '', '', '', '', 0, '0000-00-00 00:00:00', 2, 0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tables and fields quoteName are not correct in postgresql. they should be " (see the other ones)
Also the dates should be 1970-01-01 00:00:00, not 0000-00-00 00:00:00

@roland-d roland-d added this to the Joomla 3.6.0 milestone May 8, 2016
@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

Download of the brach is: https://github.com/roland-d/joomla-cms/archive/cleanup-installer-plugins.zip

@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

I have tesed the clean install and disable the plugins both works!

I have not got the update server runnung i will try it later.

@alikon
Copy link
Contributor

alikon commented May 8, 2016

I have tested this item ✅ successfully on 8b9add8

tested on a clean installation


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10308.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10308.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2016
@Kubik-Rubik
Copy link
Member

Thank you @roland-d and testers!

@Kubik-Rubik Kubik-Rubik merged commit 53aad6f into joomla:staging May 8, 2016
@zero-24
Copy link
Contributor

zero-24 commented May 11, 2016

please remove the label @joomla-cms-bot

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2016
@roland-d roland-d deleted the cleanup-installer-plugins branch January 29, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants