Skip to content

[4.0] Choices.js #27083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brianteeman opened this issue Nov 15, 2019 · 4 comments
Closed

[4.0] Choices.js #27083

brianteeman opened this issue Nov 15, 2019 · 4 comments

Comments

@brianteeman
Copy link
Contributor

This library has recently had two breaking change releases that we have not consumed because of the criteria correctly set in package.json.

Creating a PR to update our release is easy but I'm not sure if the breaking changes have an impact on us or even how to check them.

https://github.com/jshjohnson/Choices/releases

@Fedik
Copy link
Member

Fedik commented Nov 16, 2019

They dropped placeholder param for <select> input Choices-js/Choices#731 😄 crazy

Need to check what we can do.
Other stuff seems to work fine.

@Fedik
Copy link
Member

Fedik commented Nov 17, 2019

please test #27093

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/27083

@alikon
Copy link
Contributor

alikon commented Nov 17, 2019

closed as we have a pr #27093


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27083.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants