[5.0] b/c plugin for deprecation (#40664)

* Add compatibility plugin and move classmap

* remove classmap from unit tests

* Use namespace for html helper tests

* PoC for Table::getInstance JTable prefix

* Revert cache plugin change

* PoC HTMLHelper correct namespace

* revert drone change

* Activate the plugin by default on new installations

* Fix system plugins ordering in base.sql

* Add insert of extension to update SQL

* Add to core plugins in ExtensionHelper

* Replace JTable references, revert Table::getInstance logic

* Add Table::getInstance JTable logic including explanation

* Cleanup plugin

* Disable again for new installations

* Activate B/C plugin on new installation

* Initialise the Extension table with the real database object

* Support custom database object on language load

* Fix wrong function usage

* Add renamed non PascalCase table aliases and fix occurrence

* Disable plugin on new installations again

---------

Co-authored-by: Richard Fath <[email protected]>

Author: HLeithner

administrator/components/com_admin/sql/updates/mysql/5.0.0-2023-03-11.sql

@@ -1 +1,4 @@
 DROP TABLE IF EXISTS `#__utf8_conversion`;
+
+INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `locked`, `manifest_cache`, `params`, `custom_data`, `ordering`, `state`) VALUES
+(0, 'plg_system_compat', 'plugin', 'compat', 'system', 0, 1, 1, 0, 1, '', '{"classes_aliases":"1"}', '', 0, 0);

administrator/components/com_admin/sql/updates/postgresql/5.0.0-2023-03-11.sql

@@ -1 +1,4 @@
 DROP TABLE IF EXISTS "#__utf8_conversion";
+
+INSERT INTO "#__extensions" ("package_id", "name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "locked", "manifest_cache", "params", "custom_data", "ordering", "state") VALUES
+(0, 'plg_system_compat', 'plugin', 'compat', 'system', 0, 1, 1, 0, 1, '', '{"classes_aliases":"1"}', '', 0, 0);

administrator/components/com_associations/src/Model/AssociationsModel.php

@@ -395,7 +395,7 @@ protected function getListQuery()
         $baselevel = 1;
 
         if ($categoryId = $this->getState('filter.category_id')) {
-            $categoryTable = Table::getInstance('Category', 'JTable');
+            $categoryTable = Table::getInstance('Category', '\\Joomla\\CMS\\Table\\');
             $categoryTable->load($categoryId);
             $baselevel = (int) $categoryTable->level;
 

administrator/components/com_banners/src/Model/BannerModel.php

@@ -164,7 +164,7 @@ protected function canDelete($record)
      * for alias and title to use the batch move and copy methods
      *
      * @param   integer  $categoryId  The target category id
-     * @param   Table    $table       The JTable within which move or copy is taking place
+     * @param   Table    $table       The \Joomla\CMS\Table\Table within which move or copy is taking place
      *
      * @return  void
      *

administrator/components/com_banners/src/Table/BannerTable.php

@@ -160,7 +160,7 @@ public function check()
     /**
      * Overloaded bind function
      *
-     * @param   mixed  $array   An associative array or object to bind to the \JTable instance.
+     * @param   mixed  $array   An associative array or object to bind to the \Joomla\CMS\Table\Table instance.
      * @param   mixed  $ignore  An optional array or space separated list of properties to ignore while binding.
      *
      * @return  boolean  True on success

administrator/components/com_categories/src/Controller/AjaxController.php

@@ -64,7 +64,7 @@ public function fetchAssociations()
 
             // Add the title to each of the associated records
             Table::addIncludePath(JPATH_ADMINISTRATOR . '/components/com_categories/tables');
-            $categoryTable = Table::getInstance('Category', 'JTable');
+            $categoryTable = Table::getInstance('Category', '\\Joomla\\CMS\\Table\\');
 
             foreach ($associations as $lang => $association) {
                 $categoryTable->load($association->id);

administrator/components/com_contact/src/Model/ContactsModel.php

@@ -323,7 +323,7 @@ protected function getListQuery()
         // Case: Using both categories filter and by level filter
         if (count($categoryId)) {
             $categoryId       = ArrayHelper::toInteger($categoryId);
-            $categoryTable    = Table::getInstance('Category', 'JTable');
+            $categoryTable    = Table::getInstance('Category', '\\Joomla\\CMS\\Table\\');
             $subCatItemsWhere = [];
 
             // @todo: Convert to prepared statement

administrator/components/com_contact/src/Table/ContactTable.php

@@ -140,7 +140,7 @@ public function store($updateNulls = true)
      *
      * @return  boolean  True on success, false on failure
      *
-     * @see     \JTable::check
+     * @see     \Joomla\CMS\Table\Table::check
      * @since   1.5
      */
     public function check()

administrator/components/com_content/src/Controller/AjaxController.php

@@ -61,7 +61,7 @@ public function fetchAssociations()
             unset($associations[$excludeLang]);
 
             // Add the title to each of the associated records
-            $contentTable = Table::getInstance('Content', 'JTable');
+            $contentTable = Table::getInstance('Content', '\\Joomla\\CMS\\Table\\');
 
             foreach ($associations as $lang => $association) {
                 $contentTable->load($association->id);

administrator/components/com_content/src/Model/ArticlesModel.php

@@ -394,7 +394,7 @@ protected function getListQuery()
         // Case: Using both categories filter and by level filter
         if (count($categoryId)) {
             $categoryId       = ArrayHelper::toInteger($categoryId);
-            $categoryTable    = Table::getInstance('Category', 'JTable');
+            $categoryTable    = Table::getInstance('Category', '\\Joomla\\CMS\\Table\\');
             $subCatItemsWhere = [];
 
             foreach ($categoryId as $key => $filter_catid) {