[5.1] Replace hard coded img element by JLayout joomla.html.image and DRY (#42508)

Author: hans2103

modules/mod_banners/tmpl/default.php

@@ -13,6 +13,7 @@
 use Joomla\CMS\Helper\MediaHelper;
 use Joomla\CMS\HTML\HTMLHelper;
 use Joomla\CMS\Language\Text;
+use Joomla\CMS\Layout\LayoutHelper;
 use Joomla\CMS\Router\Route;
 use Joomla\CMS\Uri\Uri;
 ?>
@@ -40,6 +41,17 @@
                 <?php $alt = $alt ?: Text::_('MOD_BANNERS_BANNER'); ?>
                 <?php $width = $item->params->get('width'); ?>
                 <?php $height = $item->params->get('height'); ?>
+                <?php $imageAttribs = [
+                    'src' => $baseurl . $imageurl,
+                    'alt' => $alt
+                ];?>
+                <?php if (!empty($width)) : ?>
+                    <?php $imageAttribs['width'] = $width; ?>
+                <?php endif; ?>
+                <?php if (!empty($height)) : ?>
+                    <?php $imageAttribs['height'] = $height; ?>
+                <?php endif; ?>
+                <?php $image = LayoutHelper::render('joomla.html.image', $imageAttribs); ?>
                 <?php if ($item->clickurl) : ?>
                     <?php // Wrap the banner in a link ?>
                     <?php $target = $params->get('target', 1); ?>
@@ -48,16 +60,7 @@
                         <a
                             href="<?php echo $link; ?>" target="_blank" rel="noopener noreferrer"
                             title="<?php echo htmlspecialchars($item->name, ENT_QUOTES, 'UTF-8'); ?>">
-                            <img
-                                src="<?php echo $baseurl . $imageurl; ?>"
-                                alt="<?php echo htmlspecialchars($alt, ENT_QUOTES, 'UTF-8'); ?>"
-                                <?php if (!empty($width)) {
-                                    echo 'width="' . $width . '"';
-                                } ?>
-                                <?php if (!empty($height)) {
-                                    echo 'height="' . $height . '"';
-                                } ?>
-                            >
+                            <?php echo $image; ?>
                         </a>
                     <?php elseif ($target == 2) : ?>
                         <?php // Open in a popup window ?>
@@ -66,46 +69,19 @@
                                 'toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,width=780,height=550');
                                 return false"
                             title="<?php echo htmlspecialchars($item->name, ENT_QUOTES, 'UTF-8'); ?>">
-                            <img
-                                src="<?php echo $baseurl . $imageurl; ?>"
-                                alt="<?php echo htmlspecialchars($alt, ENT_QUOTES, 'UTF-8'); ?>"
-                                <?php if (!empty($width)) {
-                                    echo 'width="' . $width . '"';
-                                } ?>
-                                <?php if (!empty($height)) {
-                                    echo 'height="' . $height . '"';
-                                } ?>
-                            >
+                            <?php echo $image; ?>
                         </a>
                     <?php else : ?>
                         <?php // Open in parent window ?>
                         <a
                             href="<?php echo $link; ?>"
                             title="<?php echo htmlspecialchars($item->name, ENT_QUOTES, 'UTF-8'); ?>">
-                            <img
-                                src="<?php echo $baseurl . $imageurl; ?>"
-                                alt="<?php echo htmlspecialchars($alt, ENT_QUOTES, 'UTF-8'); ?>"
-                                <?php if (!empty($width)) {
-                                    echo 'width="' . $width . '"';
-                                } ?>
-                                <?php if (!empty($height)) {
-                                    echo 'height="' . $height . '"';
-                                } ?>
-                            >
+                            <?php echo $image; ?>
                         </a>
                     <?php endif; ?>
                 <?php else : ?>
                     <?php // Just display the image if no link specified ?>
-                    <img
-                        src="<?php echo $baseurl . $imageurl; ?>"
-                        alt="<?php echo htmlspecialchars($alt, ENT_QUOTES, 'UTF-8'); ?>"
-                        <?php if (!empty($width)) {
-                            echo 'width="' . $width . '"';
-                        } ?>
-                        <?php if (!empty($height)) {
-                            echo 'height="' . $height . '"';
-                        } ?>
-                    >
+                    <?php echo $image; ?>
                 <?php endif; ?>
             <?php endif; ?>
         <?php endif; ?>