Get ordering from model in module controller (#37635)

* Get ordering from model in module controller

* imports

* Phase 1 convert BRANCH to PSR-12

* Phase 2 convert BRANCH to PSR-12

---------

Co-authored-by: Joomla! Bot <[email protected]>

Author: laoneo

administrator/components/com_modules/src/Controller/ModuleController.php

@@ -10,7 +10,6 @@
 
 namespace Joomla\Component\Modules\Administrator\Controller;
 
-use Joomla\CMS\Factory;
 use Joomla\CMS\Form\Form;
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\MVC\Controller\FormController;
@@ -19,7 +18,6 @@
 use Joomla\CMS\Router\Route;
 use Joomla\CMS\Session\Session;
 use Joomla\CMS\Uri\Uri;
-use Joomla\Database\ParameterType;
 
 // phpcs:disable PSR1.Files.SideEffects
 \defined('_JEXEC') or die;
@@ -279,21 +277,13 @@ public function orderPosition()
             $app->close();
         }
 
-        $db       = Factory::getDbo();
-        $clientId = (int) $clientId;
-        $query    = $db->getQuery(true)
-            ->select($db->quoteName(['position', 'ordering', 'title']))
-            ->from($db->quoteName('#__modules'))
-            ->where($db->quoteName('client_id') . ' = :clientid')
-            ->where($db->quoteName('position') . ' = :position')
-            ->order($db->quoteName('ordering'))
-            ->bind(':clientid', $clientId, ParameterType::INTEGER)
-            ->bind(':position', $position);
-
-        $db->setQuery($query);
+        $model = $this->getModel('Modules', 'Administrator', ['ignore_request' => true]);
+        $model->setState('client_id', $clientId);
+        $model->setState('filter.position', $position);
+        $model->setState('list.ordering', 'a.ordering');
 
         try {
-            $orders = $db->loadObjectList();
+            $orders = $model->getItems();
         } catch (\RuntimeException $e) {
             $app->enqueueMessage($e->getMessage(), 'error');