Remove one-time-use variables

frankmayer · frankmayer · commit a64413c1fae1 · 2016-12-13T23:37:25.000+02:00
diff --git a/components/com_content/helpers/icon.php b/components/com_content/helpers/icon.php
@@ -81,9 +81,7 @@ public static function email($article, $params, $attribs = array(), $legacy = fa
 		$attribs['onclick'] = "window.open(this.href,'win2','" . $status . "'); return false;";
 		$attribs['rel']     = 'nofollow';
 
-		$output = JHtml::_('link', JRoute::_($url), $text, $attribs);
-
-		return $output;
+		return JHtml::_('link', JRoute::_($url), $text, $attribs);
 	}
 
 	/**
diff --git a/components/com_content/helpers/query.php b/components/com_content/helpers/query.php
@@ -212,9 +212,7 @@ public static function buildVotingQuery($params = null)
 			$join = '';
 		}
 
-		$results = array ('select' => $select, 'join' => $join);
-
-		return $results;
+		return array ('select' => $select, 'join' => $join);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,7 @@ public static function email($article, $params, $attribs = array(), $legacy = fa`
`81`	`81`	`$attribs['onclick'] = "window.open(this.href,'win2','" . $status . "'); return false;";`
`82`	`82`	`$attribs['rel'] = 'nofollow';`
`83`	`83`
`84`		`- $output = JHtml::_('link', JRoute::_($url), $text, $attribs);`
`85`		`-`
`86`		`- return $output;`
	`84`	`+ return JHtml::_('link', JRoute::_($url), $text, $attribs);`
`87`	`85`	`}`
`88`	`86`
`89`	`87`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -212,9 +212,7 @@ public static function buildVotingQuery($params = null)`
`212`	`212`	`$join = '';`
`213`	`213`	`}`
`214`	`214`
`215`		`- $results = array ('select' => $select, 'join' => $join);`
`216`		`-`
`217`		`- return $results;`
	`215`	`+ return array ('select' => $select, 'join' => $join);`
`218`	`216`	`}`
`219`	`217`
`220`	`218`	`/**`