Update recaptcha.php

vinespie · vinespie · commit 84d9352021d1 · 2016-05-23T16:35:56.000+02:00
Changing load order and adding a comment. Proposed by @piotr-cz
diff --git a/plugins/captcha/recaptcha/recaptcha.php b/plugins/captcha/recaptcha/recaptcha.php
@@ -58,9 +58,11 @@ public function onInit($id = 'dynamic_recaptcha_1')
 		}
 		else
 		{
-			$file = 'https://www.google.com/recaptcha/api.js?onload=JoomlaInitReCaptcha2&render=explicit&hl=' . JFactory::getLanguage()->getTag();
-			JFactory::getDocument()->addScript($file, "text/javascript", true);
+			// Load callback first for browser compatibility
 			JHtml::_('script', 'plg_captcha_recaptcha/recaptcha.min.js', false, true);
+			
+			$file = 'https://www.google.com/recaptcha/api.js?onload=JoomlaInitReCaptcha2&render=explicit&hl=' . JFactory::getLanguage()->getTag();
+			JHtml::_('script', $file);
 		}
 
 		return true;

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,11 @@ public function onInit($id = 'dynamic_recaptcha_1')`
`58`	`58`	`}`
`59`	`59`	`else`
`60`	`60`	`{`
`61`		`- $file = 'https://www.google.com/recaptcha/api.js?onload=JoomlaInitReCaptcha2&render=explicit&hl=' . JFactory::getLanguage()->getTag();`
`62`		`- JFactory::getDocument()->addScript($file, "text/javascript", true);`
	`61`	`+ // Load callback first for browser compatibility`
`63`	`62`	`JHtml::_('script', 'plg_captcha_recaptcha/recaptcha.min.js', false, true);`
	`63`	`+`
	`64`	`+ $file = 'https://www.google.com/recaptcha/api.js?onload=JoomlaInitReCaptcha2&render=explicit&hl=' . JFactory::getLanguage()->getTag();`
	`65`	`+ JHtml::_('script', $file);`
`64`	`66`	`}`
`65`	`67`
`66`	`68`	`return true;`