Skip to content

Commit 5553529

Browse files
brianteemanwilsonge
authored andcommitted
[4.0] Workflow [a11y] (#21488)
Remove th and scope=col from the checkall cell Add th and scope=row to the title cell
1 parent 60702b6 commit 5553529

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

administrator/components/com_workflow/tmpl/states/default.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@
5757
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
5858
<?php echo HTMLHelper::_('searchtools.sort', '', 's.ordering', $listDirn, $listOrder, null, 'asc', 'JGRID_HEADING_ORDERING', 'icon-menu-2'); ?>
5959
</th>
60-
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
60+
<td style="width:1%" class="nowrap text-center hidden-sm-down">
6161
<?php echo HTMLHelper::_('grid.checkall'); ?>
62-
</th>
62+
</td>
6363
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
6464
<?php echo HTMLHelper::_('searchtools.sort', 'JSTATUS', 's.condition', $listDirn, $listOrder); ?>
6565
</th>
@@ -116,7 +116,7 @@
116116
<td class="text-center hidden-sm-down">
117117
<?php echo HTMLHelper::_('jgrid.isdefault', $item->default, $i, 'states.', $canChange); ?>
118118
</td>
119-
<td>
119+
<th scope="row">
120120
<?php if ($canEdit) : ?>
121121
<?php $editIcon = '<span class="fa fa-pencil-square mr-2" aria-hidden="true"></span>'; ?>
122122
<a href="<?php echo $edit; ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape(addslashes($item->title)); ?>">
@@ -125,7 +125,7 @@
125125
<?php else: ?>
126126
<?php echo $item->title; ?>
127127
<?php endif; ?>
128-
</td>
128+
</th>
129129
<td class="text-center">
130130
<?php echo Text::_($item->condition); ?>
131131
</td>
@@ -138,7 +138,7 @@
138138
</table>
139139
<?php // load the pagination. ?>
140140
<?php echo $this->pagination->getListFooter(); ?>
141-
141+
142142
<?php endif; ?>
143143
<input type="hidden" name="task" value="">
144144
<input type="hidden" name="boxchecked" value="0">

administrator/components/com_workflow/tmpl/transitions/default.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@
5656
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
5757
<?php echo HTMLHelper::_('searchtools.sort', '', 't.ordering', $listDirn, $listOrder, null, 'asc', 'JGRID_HEADING_ORDERING', 'icon-menu-2'); ?>
5858
</th>
59-
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
59+
<td style="width:1%" class="nowrap text-center hidden-sm-down">
6060
<?php echo HTMLHelper::_('grid.checkall'); ?>
61-
</th>
61+
</td>
6262
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
6363
<?php echo HTMLHelper::_('searchtools.sort', 'JSTATUS', 't.published', $listDirn, $listOrder); ?>
6464
</th>
@@ -111,7 +111,7 @@
111111
<?php echo HTMLHelper::_('jgrid.published', $item->published, $i, 'transitions.', $canChange); ?>
112112
</div>
113113
</td>
114-
<td>
114+
<th scope="row">
115115
<?php if ($canEdit) : ?>
116116
<?php $editIcon = '<span class="fa fa-pencil-square mr-2" aria-hidden="true"></span>'; ?>
117117
<a href="<?php echo $edit; ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape(addslashes($item->title)); ?>">
@@ -120,7 +120,7 @@
120120
<?php else: ?>
121121
<?php echo $item->title; ?>
122122
<?php endif; ?>
123-
</td>
123+
</th>
124124
<td class="text-center">
125125
<?php if ($item->from_state_id < 0) : ?>
126126
<?php echo Text::_('JALL'); ?>

administrator/components/com_workflow/tmpl/workflows/default.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@
6767
<th scope="col" style="width:1%" class="nowrap text-center d-none d-md-table-cell">
6868
<?php echo HTMLHelper::_('searchtools.sort', '', 'w.ordering', $listDirn, $listOrder, null, 'asc', 'JGRID_HEADING_ORDERING', 'icon-menu-2'); ?>
6969
</th>
70-
<th style="width:1%" class="nowrap text-center hidden-sm-down">
70+
<td style="width:1%" class="nowrap text-center hidden-sm-down">
7171
<?php echo HTMLHelper::_('grid.checkall'); ?>
72-
</th>
72+
</td>
7373
<th scope="col" style="width:1%" class="nowrap text-center hidden-sm-down">
7474
<?php echo HTMLHelper::_('searchtools.sort', 'JSTATUS', 'w.condition', $listDirn, $listOrder); ?>
7575
</th>
@@ -141,7 +141,7 @@
141141
<?php echo HTMLHelper::_('jgrid.published', $item->published, $i, 'workflows.', $canChange); ?>
142142
</div>
143143
</td>
144-
<td>
144+
<th scope="row">
145145
<?php if ($canEdit || $canEditOwn) : ?>
146146
<?php $editIcon = '<span class="fa fa-pencil-square mr-2" aria-hidden="true"></span>'; ?>
147147
<a href="<?php echo $edit; ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape(addslashes($item->title)); ?>">
@@ -150,7 +150,7 @@
150150
<?php else: ?>
151151
<?php echo $item->title; ?>
152152
<?php endif; ?>
153-
</td>
153+
</th>
154154
<td class="text-center">
155155
<a href="<?php echo $states; ?>"><?php echo Text::_('COM_WORKFLOW_MANAGE'); ?></a>
156156
</td>
@@ -182,7 +182,7 @@
182182
</table>
183183
<?php // load the pagination. ?>
184184
<?php echo $this->pagination->getListFooter(); ?>
185-
185+
186186
<?php endif; ?>
187187
<input type="hidden" name="task" value="">
188188
<input type="hidden" name="boxchecked" value="0">

0 commit comments

Comments
 (0)