Skip to content

Commit 4f53774

Browse files
ggppdkwilsonge
authored andcommitted
[com_fields] Add Joomla loading overlay when form submit is triggered by category selector change (#13320)
* Added overlay box and message box for submit and reload form after category change * Removed commented testing code * Added language strings * CS fix, added missing spaces * Used Joomla logo spinner instead of fixed message * Reverted changes in admin lang file * CS * Revert frontend lang changes * Added Joomla loading overlay to new field form when changing field type * Added Joomla.loadingLayer show to typeHasChanged JS method too
1 parent cc5d440 commit 4f53774

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

administrator/components/com_fields/helpers/fields.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,15 +320,19 @@ public static function prepareForm($context, JForm $form, $data)
320320
* has changed
321321
*/
322322
$form->setFieldAttribute('catid', 'onchange', 'categoryHasChanged(this);');
323-
JFactory::getDocument()->addScriptDeclaration(
324-
"function categoryHasChanged(element){
323+
324+
// Preload spindle-wheel when we need to submit form due to category selector changed
325+
JFactory::getDocument()->addScriptDeclaration("
326+
function categoryHasChanged(element) {
327+
Joomla.loadingLayer('show');
325328
var cat = jQuery(element);
326329
if (cat.val() == '" . $assignedCatids . "')return;
327330
jQuery('input[name=task]').val('field.storeform');
328331
element.form.action='" . $uri . "';
329332
element.form.submit();
330333
}
331334
jQuery( document ).ready(function() {
335+
Joomla.loadingLayer('load');
332336
var formControl = '#" . $form->getFormControl() . "_catid';
333337
if (!jQuery(formControl).val() != '" . $assignedCatids . "'){jQuery(formControl).val('" . $assignedCatids . "');}
334338
});");

administrator/components/com_fields/models/fields/type.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,19 @@ function ($a, $b)
8686
$uri->setVar('view', null);
8787
$uri->setVar('layout', null);
8888

89-
JFactory::getDocument()->addScriptDeclaration(
90-
"function typeHasChanged(element){
89+
90+
JFactory::getDocument()->addScriptDeclaration("
91+
jQuery( document ).ready(function() {
92+
Joomla.loadingLayer('load');
93+
});
94+
function typeHasChanged(element){
95+
Joomla.loadingLayer('show');
9196
var cat = jQuery(element);
9297
jQuery('input[name=task]').val('field.storeform');
9398
element.form.action='" . $uri . "';
9499
element.form.submit();
95-
}");
100+
}
101+
");
96102

97103
return $options;
98104
}

0 commit comments

Comments
 (0)