Skip to content

Add an exception when not allowed to "Access Administration Interface" #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Add an exception when not allowed to "Access Administration Interface" #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/administrator/components/com_weblinks/weblinks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

if (!JFactory::getUser()->authorise('core.manage', 'com_weblinks'))
{
return JError::raiseWarning(404, JText::_('JERROR_ALERTNOAUTHOR'));
throw new JAccessExceptionNotallowed(JText::_('JERROR_ALERTNOAUTHOR'), 403);
Copy link
Contributor

@chrisdavenport chrisdavenport Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the name of that exception. In English it reads like the exception is not allowed! But I suppose there isn't much to be done about it given the autoloader, right?

Copy link
Contributor

@mbabker mbabker Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much. In our namespaced code the Exception objects either get into
their own namespace or don't have this issue of fighting with a camel cased
autoloader but can enjoy the benefit of PSR-4 rules. I don't like the
names of the cache and database exceptions I added either but it's all the
same problem in the end.

On Friday, August 19, 2016, Chris Davenport [email protected]
wrote:

In src/administrator/components/com_weblinks/weblinks.php
#262 (comment)
:

@@ -12,7 +12,7 @@

if (!JFactory::getUser()->authorise('core.manage', 'com_weblinks'))
{

  • return JError::raiseWarning(404, JText::_('JERROR_ALERTNOAUTHOR'));
  • throw new JAccessExceptionNotallowed(JText::_('JERROR_ALERTNOAUTHOR'), 403);

I don't like the name of that exception. In English it reads like the
exception is not allowed! But I suppose there isn't much to be done about
it given the autoloader, right?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/joomla-extensions/weblinks/pull/262/files/cfa32e7ec46893a49d281460600711c8df8ec7d6#r75564612,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoQ1qh4gcBAC8W_OBJRSH6qdp5LU6ks5qhjr7gaJpZM4Jo65Y
.

}

$controller = JControllerLegacy::getInstance('Weblinks');
Expand Down