You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! It would be great if you changed the active class to 'active' instead of is-active, since the dashed version can sometimes lead to some problems.
I know we can just mod the scss files, yes, no prob, but then updates would be broken (and again, yes, it would be simple to fix it up as well, but it would be simpler to keep things simple :)).
Thanks for your great code, Regards
The text was updated successfully, but these errors were encountered:
@stratboy I appreciate the suggestion; however, I believe the use of is-active is better practice. The is-* prefix is used to define selectors that are specifically for altering the state of a component.
That said, a dash in a CSS name should not lead to any problems—it is extremely common practice.
Hi! It would be great if you changed the active class to 'active' instead of is-active, since the dashed version can sometimes lead to some problems.
I know we can just mod the scss files, yes, no prob, but then updates would be broken (and again, yes, it would be simple to fix it up as well, but it would be simpler to keep things simple :)).
Thanks for your great code, Regards
The text was updated successfully, but these errors were encountered: