Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change active class to 'active' #41

Closed
stratboy opened this issue Jun 21, 2017 · 1 comment
Closed

change active class to 'active' #41

stratboy opened this issue Jun 21, 2017 · 1 comment
Labels

Comments

@stratboy
Copy link

Hi! It would be great if you changed the active class to 'active' instead of is-active, since the dashed version can sometimes lead to some problems.

I know we can just mod the scss files, yes, no prob, but then updates would be broken (and again, yes, it would be simple to fix it up as well, but it would be simpler to keep things simple :)).

Thanks for your great code, Regards

@jonsuh
Copy link
Owner

jonsuh commented Jul 7, 2017

@stratboy I appreciate the suggestion; however, I believe the use of is-active is better practice. The is-* prefix is used to define selectors that are specifically for altering the state of a component.

That said, a dash in a CSS name should not lead to any problems—it is extremely common practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants