Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

comparator function does not work. #82

Open
TheBranchDriftCatalyst opened this issue Mar 24, 2017 · 2 comments
Open

comparator function does not work. #82

TheBranchDriftCatalyst opened this issue Mar 24, 2017 · 2 comments

Comments

@TheBranchDriftCatalyst
Copy link

I was briefly trying to use the comparator function on the column configuration objects. I noticed that sorting was not working correctly for columns that were non_numeric and attaching my comparison (comparator) function had no effect. Looking into the code where the comparator is referenced I was unable to find any explicit use of the function (it's only used for a flag). There appear to be two bugs here (or I am using this incorrectly- if so please correct me)

1: comparator field on column definition object does not get triggered when present
2: sorting text columns does not cause any resorting to occur.

@TheBranchDriftCatalyst
Copy link
Author

So, this is interesting. I was switching my data model to an abstract type of model so all the keys are no longer specific to the entity being graphed, they are computed as cidx1... cidx2. I noticed keys on the data objects must not be string keyed. This solves number 2, however, number 1 still seems to be a problem.

@TheBranchDriftCatalyst
Copy link
Author

TheBranchDriftCatalyst commented Apr 4, 2017

The comparator function still appears to not be utilized, the other issue in this ticket is due to string keyed fields.

@TheBranchDriftCatalyst TheBranchDriftCatalyst changed the title comparator function and sorting NaN columns does not work. comparator function does not work. Apr 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant