checks isDirectory

- adds checks to ensure we aren't trying to read a directory as a file.
- closes #24
- thanks @jnthnjns

Author: doowb

index.js

@@ -97,8 +97,18 @@ function copyEach(files, dir, options, cb) {
 
   utils.each(files, function(filename, next) {
     var filepath = path.resolve(opts.cwd, filename);
+    if (utils.isDirectory(filepath)) {
+      next()
+      return;
+    }
     copyOne(filepath, dir, opts, next);
-  }, cb);
+  }, function(err, arr) {
+    if (err) {
+      cb(err);
+      return;
+    }
+    cb(null, arr.filter(Boolean));
+  });
 }
 
 /**

lib/utils.js

@@ -27,13 +27,39 @@ require('resolve-dir', 'resolve');
 require('to-file');
 require = fn;
 
+/**
+ * Gets the file stats for a File object.
+ *
+ * @param  {Object} `file` File object that has a `path` property.
+ * @return {Object} `fs.stat` object if successful. Otherwise an empty object.
+ */
+
 utils.stat = function(file) {
   try {
     return fs.lstatSync(file.path);
   } catch (err) {}
   return {};
 };
 
+/**
+ * Checks if the file is a directory using `fs.lstatSync`.
+ *
+ * @param  {String|Object} `file` filepath as a string or a file object with a `path` property.
+ * @return {Boolean} Returns `true` when the filepath is a directory.
+ */
+
+utils.isDirectory = function(file) {
+  if (typeof file === 'string') {
+    file = {path: file}
+  }
+
+  var stat = utils.stat(file);
+  if (stat.isDirectory) {
+    return stat.isDirectory();
+  }
+  return false;
+};
+
 /**
  * Get the base filepath from a glob.
  *

test/copy.js

@@ -7,6 +7,7 @@ var assert = require('assert');
 require('assert-path')(assert);
 require('assert-fs')(assert);
 var exists = support.exists;
+var eachExists = support.eachExists;
 var copy = require('..');
 
 describe('copy', function() {
@@ -70,13 +71,17 @@ describe('copy', function() {
     });
   });
 
-  it.only('should copy nested directories', function(cb) {
+  it('should copy nested directories', function(cb) {
     var src = ['test/fixtures/nested/**/*.txt', 'test/fixtures/nested-2/**/*'];
     var dest = 'test/actual';
-    var expected = support.createExpected(['nested/**/*.txt', 'nested-2/**/*'], {cwd: 'test/fixtures', dest: dest});
-    copy(src, dest, function(err) {
+    var expected = support.createExpected(['nested/**/*.txt', 'nested-2/**/*'], {
+      cwd: 'test/fixtures',
+      destBase: dest
+    });
+
+    copy(src, dest, {srcBase: 'test/fixtures'}, function(err) {
       if (err) return cb(err);
-      existsEach(expected, cb);
+      eachExists(expected, cb);
     });
   });
 

test/support/index.js

@@ -49,8 +49,6 @@ exports.createExpected = function(pattern, options) {
   var opts = utils.extend({cwd: process.cwd()}, options);
   var filepaths = utils.glob.sync(pattern, opts);
   return filepaths.map(function(filepath) {
-    var file = utils.toFile(path.resolve(opts.cwd, filepath), {cwd: opts.cwd, read: false});
-    file.path = path.resolve(opts.dest, file.relative);
-    return file;
+    return {dest: path.resolve(opts.destBase, filepath)};
   });
 };