Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments within IE conditional comments are removed #8

Open
LionelMarbot opened this issue Apr 18, 2016 · 3 comments
Open

Comments within IE conditional comments are removed #8

LionelMarbot opened this issue Apr 18, 2016 · 3 comments

Comments

@LionelMarbot
Copy link

Hi,

Do you think it could be possible to fix following issue?
digisfera#35

PS: A quick workaround is to put the build tags inside the conditional comment.

Best,
Lionel

@jonkemp
Copy link
Owner

jonkemp commented Apr 18, 2016

Can you change the title to "Comments within IE conditional comments are removed" because IE conditional comments are preserved. It's comments inside the conditional comments that are being removed. I would consider this a feature request.

@LionelMarbot
Copy link
Author

I agree that the current title is misleading. I will change it. However, I don't think the feature request should be about "not removing comments at all", but only about not removing <!--> when it immediately follows the opening conditional comment (e.g. <!--[if !IE]><!-->).

Removing actual comments within build tags should still be done in my opinion. What do you think?

What about "Special case of conditional comments are removed"?

@jonkemp
Copy link
Owner

jonkemp commented Apr 19, 2016

Just name it the same as digisfera#35.

@LionelMarbot LionelMarbot changed the title Conditional comment (IE) being stripped if within build tags Comments within IE conditional comments are removed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants