Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Small images have large empty margins #512

Closed
geominorai opened this issue Sep 18, 2022 · 0 comments
Closed

[BUG] Small images have large empty margins #512

geominorai opened this issue Sep 18, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@geominorai
Copy link

geominorai commented Sep 18, 2022

Describe the bug

Images with dimensions smaller than the image viewport of the post end up with large empty margins.

Fritter does not seem to expand small images to fit the viewport but seems to use the dimensions provided by Twitter that seems to assume this will be done.

It is not clear whether following Twitter's approach to expand small images this way offers a good user experience, since there is not enough resolution in these images in the first place to not look horrible or illegible after stretching. Reducing the viewport size based on the actual image dimensions might be better.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://twitter.com/k45Fuel/status/1571535136465756168
  2. See error

Screenshots

Post as seen in Fritter and Firefox.

Device

Model: Samsung Galaxy S9+
OS: Android 10
Language: English
Fritter Version: v3.0.0-beta3+20220904

@geominorai geominorai added the bug Something isn't working label Sep 18, 2022
@jonjomckay jonjomckay added this to the v3.0.0 milestone Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants