Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling error tags for <InLine> and <Wrapper> #9

Open
galvanu opened this issue Jul 28, 2014 · 1 comment
Open

Handling error tags for <InLine> and <Wrapper> #9

galvanu opened this issue Jul 28, 2014 · 1 comment

Comments

@galvanu
Copy link

galvanu commented Jul 28, 2014

According to IAB documentation:
" contains a URI to a tracking resource that the video player should request if for some reason the InLine ad could not be served"

As I saw, VASTAd object implementation (inside the constructor) doesn't extract these errors from the given .

@jonhoo
Copy link
Owner

jonhoo commented Aug 16, 2014

Yes, I intentionally did not implement these as getting the main part of the VAST parsing in place was more important. It's certainly a useful feature though, so a PR would be welcome. I think the script loading ads should be notified of the error as well (possibly by providing another callback) instead of just masking the error. Maybe the return value of the callback could be used to determine whether to show the fallback ad or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants