Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions scope #1

Open
CyrilleG opened this issue Apr 12, 2013 · 2 comments
Open

Functions scope #1

CyrilleG opened this issue Apr 12, 2013 · 2 comments

Comments

@CyrilleG
Copy link

Hi,

I'm currently working on a HTML5 video player for a French company. Your script is really helpful for my VAST developpements! Thank you for create it!

This message does not really concern an issue.

Can I suggest you a small update which can be very usefull? All your functions are in the "window" scope, it can be better if all your functions move to a specific scope like "vastVamp" or something like that :)

Regards

@jonhoo
Copy link
Owner

jonhoo commented Apr 13, 2013

It's definitely on my roadmap, but for the moment I've had to halt development on this due to several upcoming exams. I'll keep the issue open though, since this is something that should definitely be done,

@jonhoo
Copy link
Owner

jonhoo commented Apr 13, 2013

Feel free to do it yourself at submit a pull request if you have the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants