pkp#8845 Added missing property declarations

Author: jonasraoni

api/v1/stats/editorial/PKPStatsEditorialHandler.php

@@ -27,6 +27,9 @@
 
 abstract class PKPStatsEditorialHandler extends APIHandler
 {
+    /** @var string The name of the section ids query param for this application */
+    public $sectionIdsQueryParam;
+
     /**
      * Constructor
      */

api/v1/stats/publications/PKPStatsPublicationHandler.php

@@ -35,6 +35,9 @@
 
 abstract class PKPStatsPublicationHandler extends APIHandler
 {
+    /** @var string The name of the section ids query param for this application */
+    public $sectionIdsQueryParam;
+
     /**
      * Constructor
      */

classes/components/forms/FieldAutosuggestPreset.php

@@ -22,6 +22,9 @@ class FieldAutosuggestPreset extends FieldBaseAutosuggest
     /** @var array Key/value list of suggestions for this field */
     public $options = [];
 
+    /** @var array Key/value list of languages this field should support. Key = locale code. Value = locale name */
+    public $locales = [];
+
     /**
      * @copydoc Field::getConfig()
      */

classes/controllers/grid/users/reviewer/PKPReviewerGridHandler.php

@@ -78,6 +78,8 @@ class PKPReviewerGridHandler extends GridHandler
     /** @var bool Is the current user assigned as an author to this submission */
     public $_isCurrentUserAssignedAuthor;
 
+    public bool $isAuthorGrid = false;
+
 
     /**
      * Constructor
@@ -104,8 +106,6 @@ public function __construct()
             [Role::ROLE_ID_ASSISTANT],
             $assistantOperations
         );
-
-        $this->isAuthorGrid = false;
     }
 
     /**

classes/core/EntityDAO.php

@@ -31,6 +31,9 @@ abstract class EntityDAO
     /** @var string The column name for the object id in primary and settings tables */
     public $primaryKeyColumn;
 
+    /** @var array Maps schema properties for the primary table to their column names */
+    public $primaryTableColumns = [];
+
     /**
      * @var array Map schema properties to the primary table
      *

classes/form/validation/FormValidatorCustom.php

@@ -26,6 +26,9 @@ class FormValidatorCustom extends FormValidator
     /** @var bool If true, field is considered valid if user function returns false instead of true */
     public $_complementReturn;
 
+    /** @var mixed[] Arguments to pass to getMessage() */
+    public $_messageArgs = [];
+
     /** @var array If present, additional arguments to pass to the getMessage translation function
      * The user function is passed the form data as its first argument and $additionalArguments, if set, as the remaining arguments. This function must return a boolean value.
      *

classes/linkAction/request/Modal.php

@@ -35,6 +35,9 @@ class Modal extends LinkActionRequest
     /** @var array The id of any Vue instances that must be destroyed when modal closed */
     public $_closeCleanVueInstances;
 
+    /** @var string Text for the close button */
+    public $_closeButtonText;
+
     /**
      * Constructor
      *

classes/metadata/MetadataDataObjectAdapter.php

@@ -52,6 +52,9 @@ class MetadataDataObjectAdapter extends PersistableFilter
     /** @var string */
     public $_dataObjectName;
 
+    /** @var DataObject */
+    public $_targetDataObject;
+
     /**
      * Constructor
      *

classes/migration/upgrade/v3_4_0/I7191_EditorAssignments.php

@@ -21,6 +21,10 @@
 
 abstract class I7191_EditorAssignments extends \PKP\migration\Migration
 {
+    protected string $sectionDb;
+    protected string $sectionIdColumn;
+    protected string $contextColumn;
+
     /**
      * Adds a user_group_id column to the subeditor_submission_group
      * table and adds initial data. Adds foreign keys where appropriate.

classes/payment/Payment.php

@@ -43,7 +43,7 @@ class Payment
     public $assocId;
 
     /** @var int PaymentManager::PAYMENT_TYPE_... */
-    public $_type;
+    public $type;
 
     /**
      * Constructor

classes/services/queryBuilders/PKPContextQueryBuilder.php

@@ -40,6 +40,9 @@ abstract class PKPContextQueryBuilder implements EntityQueryBuilderInterface
     /** @var string search phrase */
     protected $searchPhrase = null;
 
+    /** @var string[] Selected columns */
+    protected $columns = [];
+
     /**
      * Set isEnabled filter
      *

classes/sushi/CounterR5Report.php

@@ -79,6 +79,9 @@ abstract class CounterR5Report
     /** The granularity of the usage data to include in the report. */
     protected string $granularity = 'Month';
 
+    /** @var array */
+    protected $institutionId;
+
     /**
      * Get report name defined by COUNTER.
      */

classes/xml/XMLParserDOMHandler.php

@@ -31,6 +31,9 @@ class XMLParserDOMHandler extends XMLParserHandler {
 	/** @var string reference to the current data */
 	var $currentData;
 
+    /** @var XMLNode[] */
+    var $rootNodes = [];
+
 	/**
 	 * Constructor.
 	 */

controllers/grid/eventLog/SubmissionFileEventLogGridHandler.php

@@ -23,6 +23,9 @@
 
 class SubmissionFileEventLogGridHandler extends SubmissionEventLogGridHandler
 {
+    /** @var SubmissionFile SubmissionFile */
+    public $_submissionFile;
+
     //
     // Getters/Setters
     //

controllers/grid/files/FileDateGridColumn.php

@@ -23,6 +23,9 @@
 
 class FileDateGridColumn extends GridColumn
 {
+    /** @var ?int */
+    public $_stageId;
+
     /** @var bool */
     public $_includeNotes;
 

controllers/grid/files/proof/form/ManageProofFilesForm.php

@@ -22,6 +22,9 @@
 
 class ManageProofFilesForm extends ManageSubmissionFilesForm
 {
+    /** @var int PublicationId ID. */
+    public $_publicationId;
+
     /** @var int Representation ID. */
     public $_representationId;
 

controllers/grid/queries/QueriesGridRow.php

@@ -29,6 +29,7 @@ class QueriesGridRow extends GridRow
     public $_stageId;
 
     /** @var QueriesAccessHelper */
+    public $_queriesAccessHelper;
 
     /**
      * Constructor

tests/classes/publication/PublicationTest.php

@@ -28,6 +28,8 @@
 
 class PublicationTest extends PKPTestCase
 {
+    public $publication;
+
     /**
      * @see PKPTestCase::setUp()
      */

tests/classes/security/authorization/PolicyTestCase.php

@@ -35,6 +35,7 @@ abstract class PolicyTestCase extends PKPTestCase
     protected const ROLE_ID_TEST = 0x9999;
 
     private ?Context $contextObject = null;
+    public $contextObjects;
 
     /** @var AuthorizationPolicy internal state variable that contains the policy that will be used to manipulate the authorization context */
     private ?AuthorizationPolicy $authorizationContextManipulationPolicy = null;