Skip to content

Commit b57f18e

Browse files
committed
fix(area): fix acres being treated as larger than square miles
Closes #709
1 parent 858ad7a commit b57f18e

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/conversions/measures/area.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { type Measure, MeasureKind } from '../types';
44

55
export const area: Measure = {
66
kind: MeasureKind.Area,
7-
best: { metric: ['mm2', 'cm2', 'm2', 'km2'], imperial: ['sq in', 'sq ft', 'sq mi', 'ac'] },
7+
best: { metric: ['mm2', 'cm2', 'm2', 'km2'], imperial: ['sq in', 'sq ft', 'ac', 'sq mi'] },
88
units: [
99
// https://en.wikipedia.org/wiki/Category:Units_of_area
1010
// https://en.wikipedia.org/wiki/Square_metre

src/converters/conversions/area.test.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { describe } from 'vitest';
1+
import { describe, expect, test } from 'vitest';
22
import { assertConversions } from '../../../test/assert-conversion';
3+
import { convert } from '../convert';
34

45
describe('conversions', () => {
56
assertConversions([
@@ -23,4 +24,10 @@ describe('conversions', () => {
2324
{ from: [1, 'sq yd'], to: [9, 'sq ft'] },
2425
{ from: [1, 'm2'], to: [3.861_021_585_424_458e-7, 'sq mi'] },
2526
]);
27+
28+
const squareMileInM2 = convert(1, 'sq mi').to('m2');
29+
30+
test('best conversions', () => {
31+
expect(convert(squareMileInM2, 'm2').to('best', 'imperial').toString()).toMatchInlineSnapshot(`"1 sq mi"`);
32+
});
2633
});

0 commit comments

Comments
 (0)