Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing posts with Elk fails #705

Open
pmakholm opened this issue Mar 19, 2024 · 5 comments
Open

Editing posts with Elk fails #705

pmakholm opened this issue Mar 19, 2024 · 5 comments

Comments

@pmakholm
Copy link

The Elk client seems to use the PATCH method for editing posts instead of a PUT request.

Patching Takahe to allow the PATCH request instead of a PUT request for api/views/satuses.py:statuses.edit_status() allows me to edit posts with Elk, but I'm not sure how I best allow both methods.

@shuuji3
Copy link
Contributor

shuuji3 commented Mar 19, 2024

Hi, Elk uses the JavaScript library masto.js to communicate with the API server. It seems that masto.js fixed this issue by switching from PATCH method to the PUT method just three weeks ago: neet/masto.js#1017 (comment)

This can be fixed on the Elk side by upgrading masto.js dependencies. The fix was published as v6.6.3 but Elk uses v6.5.2 now.

@pmakholm
Copy link
Author

Thanks, then I will not investigate further but just wait for Elk to use an updated masto.js.

@shuuji3
Copy link
Contributor

shuuji3 commented Mar 21, 2024

The fix has just landed on the latest Canary version (660549b@main) at https://main.elk.zone/. Please wait for the next version up (TBD) when you are using the stable version https://elk.zone etc.

I confirmed the fix with takahe.social account:

Screenshot from 2024-03-22 00-46-42

@shuuji3
Copy link
Contributor

shuuji3 commented Mar 31, 2024

This fix was released to the stable version v0.13.1 yesterday: https://github.com/elk-zone/elk/releases/tag/v0.13.1

@AstraLuma
Copy link
Contributor

Is there still work for Takahē?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants