Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copy button in the recieve tab does not work. #159

Closed
alexwaltz opened this issue Mar 7, 2022 · 4 comments · Fixed by #165
Closed

The copy button in the recieve tab does not work. #159

alexwaltz opened this issue Mar 7, 2022 · 4 comments · Fixed by #165
Assignees
Labels
bug Something isn't working

Comments

@alexwaltz
Copy link

When trying to copy the receiving address, the "Copy" button does not work.

I am using the app on Umbrel, on Firefox on a Mac.

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Mar 8, 2022

Can reproduce on Linux/Firefox if site is served from an insecure location e.g. http://dev.local (not https:// not localhost). window.isSecureContext is false. Error in console is Uncaught TypeError: navigator.clipboard is undefined. Can be verified on http://permission.site (Async Clipboard API > Write Text).

Good further links here: https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined

@theborakompanioni theborakompanioni added the bug Something isn't working label Mar 8, 2022
@ghost
Copy link

ghost commented Mar 8, 2022

Is non-https the default on Umbrel?

@neb-b
Copy link
Contributor

neb-b commented Mar 8, 2022

@dnlggr yes getumbrel/umbrel-os#251

I'd be interested in working on this issue if the suggested fix from that stack overflow is acceptable - creating a hidden input then selecting and running document.execCommand('copy') on it

@ghost
Copy link

ghost commented Mar 9, 2022

@neb-b Awesome! Feel free to open a PR if you have something that works.

@ghost ghost closed this as completed in #165 Mar 9, 2022
@dergigi dergigi added this to JAM Mar 10, 2022
@dergigi dergigi moved this to Done ✅ in JAM Mar 10, 2022
@dergigi dergigi added this to the v0.0.4 - Bugfixes & Cleanup milestone Mar 10, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants