Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zlocation-detail=none #53

Closed
kornelski opened this issue Sep 11, 2023 · 2 comments · Fixed by #54
Closed

-Zlocation-detail=none #53

kornelski opened this issue Sep 11, 2023 · 2 comments · Fixed by #54
Assignees
Labels
enhancement New feature or request

Comments

@kornelski
Copy link
Contributor

There's a nightly flag rust-lang/rust#89920 that removes file/line/column information from panics and [track_caller]. Apart from reduction in the location data, this sometimes also lets the compiler unify code paths of multiple panics into one.

@johnthagen johnthagen self-assigned this Sep 11, 2023
@johnthagen johnthagen added the enhancement New feature or request label Sep 11, 2023
@johnthagen
Copy link
Owner

Thanks @kornelski!

Do you know if this affects panic = "abort" or -Z build-std-features=panic_immediate_abort?

@kornelski
Copy link
Contributor Author

It helps with panic=abort (locations are still printed), but is mostly unnecessary when using panic_immediate_abort (std inlines panic code, and the locations are optimized out). It's still possible to use caller locations for non-panicking code, e.g. tokio collects them for showing task locations in tokio-console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants