Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for benches #5

Open
dsietz opened this issue Feb 28, 2019 · 2 comments
Open

Enhancement: Add support for benches #5

dsietz opened this issue Feb 28, 2019 · 2 comments

Comments

@dsietz
Copy link

dsietz commented Feb 28, 2019

Example

[user@localhost my-package]$ cargo bench  -- -Z unstable-options --format json | cargo2junit > test-results.xml
    Finished release [optimized] target(s) in 0.07s
     Running target/release/deps/mylib-0841b1c2beb997da
     Running target/release/deps/mybin-51a51b3413cebaff
     Running target/release/deps/01_bench-0a604b4c894de629
Error: Custom { kind: Other, error: StringError("Error parsing \'{ \"type\": \"bench\", \"name\": \"test_status_code_ok\", \"median\": 1604, \"deviation\": 459 }\': unknown variant `bench`, expected `suite` or `test` at line 1 column 17") }
@johnterickson
Copy link
Owner

Thanks for the report, @dsietz. I'm going to wait until the schema is resolved per rust-lang/rust#49359 before I make more progress here.

Are you thinking we'd map "median" to the JUnit "duration"?

@dsietz
Copy link
Author

dsietz commented Mar 1, 2019

Thanks for the report, @dsietz. I'm going to wait until the schema is resolved per rust-lang/rust#49359 before I make more progress here.

Are you thinking we'd map "median" to the JUnit "duration"?

I think that would be a good mapping. But how would the deviation be mapped? The 2 attributes go hand in hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants