Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new create-subscription API #2

Closed
goodmind opened this issue Apr 8, 2018 · 2 comments
Closed

Use new create-subscription API #2

goodmind opened this issue Apr 8, 2018 · 2 comments

Comments

@goodmind
Copy link

goodmind commented Apr 8, 2018 •
edited
Loading

http://npmjs.com/create-subscription
@johnlindquist
Copy link
Owner

react-streams follows a similar pattern (getting next value on getDerivedStateFromProps and subscribing on componentDidMount). I see no reason to use their api.

@johnlindquist
Copy link
Owner

Had a chat with Brian Vaughn about being async safe:
#4 (comment)

@sebinsua sebinsua mentioned this issue Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnlindquist @goodmind