Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single window, simpler navigation #509

Closed
bertob opened this issue Jul 2, 2020 · 5 comments
Closed

Single window, simpler navigation #509

bertob opened this issue Jul 2, 2020 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@bertob
Copy link
Contributor

bertob commented Jul 2, 2020

Currently if you open a book from the Catalogs view, the book opens full-screen, but the original window is also still around and visible in the Shell overview:

image

There's also no obvious way to go back to the Catalogs view, other than closing the window. The Library view has a similar but different problem, because the only way to go back from the book view to the library is via an entry in the primary menu, which is not very easy to find.

I'd propose keeping everything in a single window, and using a standard hierarchical navigation scheme with back buttons (like GNOME Books, along with most other GNOME apps). The main differences would be

  • All navigation happens inside the main window
  • A "back" button in the headerbar of the reader view
  • The book detail view would be inside the main window with a back button, rather than a dialog. The previous/next buttons might have to be dropped in order for that to work.

In addition to being simpler and clearer, this would also have the advantage of working better in an adaptive/mobile context.

Edit: I should note that this is all based on the current behavior in master, if I'm commenting on something WIP that's going to change anyway feel free to close :)

@bertob bertob added the enhancement New feature or request label Jul 2, 2020
@johnfactotum
Copy link
Owner

Related to #446.

There's also no obvious way to go back to the Catalogs view, other than closing the window.

Currently there's indeed no other way, because the window is modal -- because the book details dialog is modal, so the only way to present a usable window (without closing the dialog, which I didn't want to do because that means losing the position in the catalog view) is to make it modal too. This can be solved by not using a dialog for the book details view.

The Library view has a similar but different problem, because the only way to go back from the book view to the library is via an entry in the primary menu, which is not very easy to find.

The easiest fix would be to add a back button to the headerbar. It's not as nice as having everything in a single window, but might be good until I have the time (and energy) to merge everything into a single window.

The previous/next buttons might have to be dropped in order for that to work.

I think maybe they can be kept inside the window's main area (i.e. not in the headerbar) on the sides when the window is wide enough? (Which would be the more natural placement than the headerbar, anyway.)

Edit: I should note that this is all based on the current behavior in master, if I'm commenting on something WIP that's going to change anyway feel free to close :)

I just released 2.4.0 :)

@bertob
Copy link
Contributor Author

bertob commented Jul 18, 2020

The easiest fix would be to add a back button to the headerbar. It's not as nice as having everything in a single window, but might be good until I have the time (and energy) to merge everything into a single window.

Agreed, a back button in the headerbar is also the pattern most other GNOME apps are using to go from content views back to the main view. Not exactly sure how that would work without merging all the windows into one though?

I think maybe they can be kept inside the window's main area (i.e. not in the headerbar) on the sides when the window is wide enough? (Which would be the more natural placement than the headerbar, anyway.)

That could also work, but I wonder if it's needed? I'm not quite sure what the use case of moving between book detail views within one category is.

@johnfactotum
Copy link
Owner

A question: does this mean that it would no longer support opening multiple books at a time? Otherwise one could end up with multiple instances of the library view. But the ability to open multiple books (or even multiple instances of the same book) at the same time is quite important, especially for reading technical materials, or other nonfiction books, and I would hate to lose that ability.

@bertob
Copy link
Contributor Author

bertob commented Jan 10, 2021

Is having multiple instances of the library open at the same time a problem? If that's a concern I think there are ways to avoid it, e.g. having an explicit "open in separate window" action on books in the library.

@johnfactotum johnfactotum added this to the 3.0 milestone Aug 17, 2021
@johnfactotum
Copy link
Owner

OPDS support is still WIP in the gtk4 branch, but it does have everything in a single window now.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants