Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page swipe does nothing in RTL manga #1291

Closed
linyaa-kiwi opened this issue Apr 5, 2024 · 2 comments
Closed

Page swipe does nothing in RTL manga #1291

linyaa-kiwi opened this issue Apr 5, 2024 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@linyaa-kiwi
Copy link

Page swipe, by either touchscreen or touchpad, does nothing in RTL manga.

Expected behavior

In RTL manga, the following works correctly:

  • Changing pages with keyboard arrow keys.
  • Changing pages with UI slider.
  • Changing pages with the arrow buttons at each end of UI slider.

The following does not work. It does absolutely nothing.

  • Changing pages with touchscreen swipe.
  • Changing pages with touchpad swipe.

Version:

  • Foliate version: 3.1.1
  • OS/Distribution and version: Fedora 40
  • Desktop environment: Gnome 46.0
  • Installation method: Installed from source, and installed from Flatpak, both have bug.

Additional context

I love Foliate. Thanks for making a greap app!

I've never debugged a GTK app before, but I can help if you provide a little guidance. For example, how do I insert debug log messages into the javascript and view them?

I began examing the scroll code in epub.js, and how dx/dy and vx/vy are processed, but I became lost without the ability to insert debug messages.

@linyaa-kiwi linyaa-kiwi added the bug Something isn't working label Apr 5, 2024
@johnfactotum
Copy link
Owner

johnfactotum commented Apr 6, 2024

It's not really possible to do that with the current fixed-layout renderer, which doesn't support offsetting and snapping the page (the scrollBy() and snap() methods of the paginator). Apart from implementing those, one workaround would be to partially undo d3619e7, to get back non-1-to-1 gestures for fixed-layout books.

Technically this is a duplicate of #1225, as all fixed layout books, including PDF, use the same renderer and have the same problem.

@johnfactotum
Copy link
Owner

Closing as duplicate of #1225

@johnfactotum johnfactotum closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2024
@johnfactotum johnfactotum added the duplicate This issue or pull request already exists label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants