Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing reserved TLDs #330

Open
hfz1337 opened this issue Apr 29, 2024 · 1 comment
Open

Add some missing reserved TLDs #330

hfz1337 opened this issue Apr 29, 2024 · 1 comment

Comments

@hfz1337
Copy link

hfz1337 commented Apr 29, 2024

It looks like the following TLDs (commonly used in local network hosts) are not in the list of TLDs (.tld_set_snapshot):

.local
.localdomain
.domain
.lan
.home
.corp

Edit: I just noticed the extra_suffixes kwarg in the TLDExtract class, so this may not be needed actually.
Feel free to close this issue if you think the above TLDs shouldn't be considered by default.

@john-kurkowski
Copy link
Owner

I'll think about this.

On one hand, this library doesn't define any suffixes, it leaves those to the Public Suffix List, emphasis on "public." See this FAQ entry. The FAQ also mentions your extra_suffixes workaround, right.

On the other hand, the Public Suffix List is tracking a similar issue in publicsuffix/list#1681. The upstream list may one day include the recommended private TLDs. In the context of this library, the recommended private TLDs do appear separate and reserved, like they could be treated differently, to distinguish them from an arbitrary private domain like www.localhost.asdfghjkl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants