Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic enum types hypothetically could miss deprecated/experimental flags #468

Closed
joffrey-bion opened this issue Dec 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented Dec 7, 2024

Enums that are declared inline in some parameters are extracted into separate named types as a workaround for ChromeDevTools/devtools-protocol#244.

During the extraction process, we should propagate the deprecated and experimental status from the parameter or the containing event/command/type to the extracted enum type.

If the enum is used in both deprecated and non deprecated declarations, it means the enum itself is still maintained and can be considered non-deprecated (it just happens to be used in a deprecated declaration). Same for experimental enums.

Note: currently no extracted enum is affected by this.

@joffrey-bion joffrey-bion added the bug Something isn't working label Dec 7, 2024
@joffrey-bion joffrey-bion changed the title Synthetic enum types don't have proper deprecated/experimental flags Synthetic enum types hypothetically could have proper deprecated/experimental flags Dec 7, 2024
@joffrey-bion joffrey-bion changed the title Synthetic enum types hypothetically could have proper deprecated/experimental flags Synthetic enum types hypothetically could miss deprecated/experimental flags Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant