Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensions struct bundling width and height #4

Open
jofas opened this issue Feb 12, 2023 · 0 comments
Open

Dimensions struct bundling width and height #4

jofas opened this issue Feb 12, 2023 · 0 comments
Labels
E-medium Experience: Medium E-mentor Experience: Has instructions on how to get started with a fix good first issue Good for newcomers
Milestone

Comments

@jofas
Copy link
Owner

jofas commented Feb 12, 2023

width and height variables throughout the codebase should be replaced with a serializable dimensions struct (best put in the src/util/frame.rs file):

struct Dimensions {
  width: usize,
  height: usize,
}

This should include the Frame struct:

mgart/src/util/frame.rs

Lines 17 to 22 in 0c7ddbb

#[derive(Debug, Clone)]
pub struct Frame<T> {
width: usize,
height: usize,
buf: Vec<T>,
}

And the jsonnet API

@jofas jofas added good first issue Good for newcomers E-medium Experience: Medium E-mentor Experience: Has instructions on how to get started with a fix labels Feb 12, 2023
@jofas jofas added this to the Code Quality milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium Experience: Medium E-mentor Experience: Has instructions on how to get started with a fix good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant