Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect logic between -da, -ds and -dg in CLI #790

Closed
nqzero opened this issue Oct 5, 2017 · 2 comments
Closed

Fix incorrect logic between -da, -ds and -dg in CLI #790

nqzero opened this issue Oct 5, 2017 · 2 comments
Milestone

Comments

@nqzero
Copy link

nqzero commented Oct 5, 2017

it seems that unless -da is given, the -ds and -dg flags are ignored

it would seem more natural if, and the help page seems to suggest this, -da implied both -ds and -dg, and if either of the -ds or -dg flags was given without a -da, that they would take effect

the current behavior also breaks backwards compatibility, ie scripts that used to generate public fields without getters or setters now generate private fields with getters and setters

workaround: use -da -dg -ds

@joelittlejohn joelittlejohn added this to the 0.5.2 milestone Oct 9, 2017
@joelittlejohn
Copy link
Owner

Yes agreed, -dg should imply -da, and -ds should imply -da too. Will fix this ASAP.

@joelittlejohn joelittlejohn modified the milestones: 0.5.2, 1.0.0-alpha2 Feb 1, 2018
@joelittlejohn joelittlejohn changed the title the new -ds and -dg flags usage is Fix incorrect logic between -da, -ds and -dg in CLI Feb 4, 2018
@nqzero
Copy link
Author

nqzero commented Mar 27, 2018

i just tried out the alpha2 release and it appears that by itself -da does nothing. -dg -ds does disable both and make the fields public. seems like -da should either be an alias for -dg -ds (for backwards compatibility) or should just be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants