Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default tag doesn't work for empty string #320

Closed
jwierzbo opened this issue Mar 20, 2015 · 2 comments
Closed

default tag doesn't work for empty string #320

jwierzbo opened this issue Mar 20, 2015 · 2 comments
Milestone
0.4.11

Comments

@jwierzbo
Copy link

myString : { "type":"string", "default":""}
will generate:

private String v;

instead of:

private String v = "";
@joelittlejohn
Copy link
Owner

Thanks for reporting this. We'll get this fixed for the next version. I simply didn't anticipate people doing this so at the moment the plugin only applies the default if the string is not empty.

@joelittlejohn joelittlejohn added this to the 0.4.11 milestone Mar 20, 2015
@jwierzbo
Copy link
Author

@joelittlejohn PR opened, please review

@jwierzbo jwierzbo mentioned this issue Mar 23, 2015
Merged
@joelittlejohn joelittlejohn changed the title default tag doesn't works for empty string default tag doesn't work for empty string Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.11
Development

No branches or pull requests
2 participants
@joelittlejohn @jwierzbo