chore(PRO-3138): solve deprecations; cleanup code #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
5af48de to
32faea2
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
32faea2 to
06ef21c
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
06ef21c to
7f2dbdd
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
7f2dbdd to
467c47e
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
467c47e to
245ab0b
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
245ab0b to
32d642c
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
32d642c to
a46c8ff
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
a46c8ff to
75036d1
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
Member
Author
|
@nemanjajojic Hi, I've redone the PR, can you please review and if you like we could have a slack huddle. Now I left the PHP version at 8, require-dev is the newest relevant stuff, here I don't care about the older or newer flix-tech/avro-serde-php version, because it's only used in tests. |
haeber
force-pushed
the
chore/PRO-3138/solve-deprecations
branch
from
75036d1 to
fe04be8
Compare
1 Privacy Issues discovered by Privado for php-kafka-lib project Check ResultRemediate all High sensitivity issues before merging the PR.
|
Member
Author
|
Ping. |
Member
Author
|
@jobcloud/publication-team-be Could you please take a look? Thanks in advance. |
Contributor
Hi @haeber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jobcloud.atlassian.net/browse/PRO-3138