Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant triggers questionable active state #68

Open
eXpl0it3r opened this issue Jul 17, 2019 · 1 comment
Open

Instant triggers questionable active state #68

eXpl0it3r opened this issue Jul 17, 2019 · 1 comment

Comments

@eXpl0it3r
Copy link
Member

  • If you create an instant trigger in the Dashboard the trigger remains with status "active" even after the job run.
  • The "active" status of the instant trigger makes IMHO only sense:
    • If there's a delay to the trigger and the delay hasn't ran out yet
    • The trigger is currently being executed
  • IMHO instant triggers should be soft deleted as soon as they have been executed OR at least set to disabled and not being able to reenable it
  • Enabling/disabling instant triggers doesn't really make sense, unless there's a delay on the trigger, since reenabling a trigger won't actually trigger a new job run and the "active" status is, as mentioned, confusing

Additionally:

  • I can't seem to delete any of the triggers, the delete button is disabled for all triggers, but that maybe a configuration somewhere?
@olibanjoli
Copy link
Contributor

The dashboard is only rudimentarily implemented. There is still a lot to be optimized. A few thoughts:

  • Active status also makes sense if the job has not yet been executed (e.g. MaxConcurrentJobs prevents the job from being executed). This is of course an edge case.
  • I think it would be better if we didn't soft-delete the triggers but filter them in the UI and display them more clearly.

Unfortunately, the delete function has not yet been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants