Exposing textDocument/highlight as a function to go on eldoc-documentation-functions

[bigodel]

As the title says, I'd like to have the function that highlights symbols in the document (currently that'd be eglot--highlight-piggyback) be public to be used in eldoc-documentation-functions. The reasoning for it is that, ideally, eldoc-documentation-functions would have only eglot-eldoc-signature-function to show the function's signature (although I know many language servers have a very poor implementation of textDocument/signatureHelp so I do understand why eglot-eldoc-hover-function is there by default), so it would be interesting to enable highlighting without having to enable hover. eldoc-documentation-functions might not be the best place for this, though, but I can't think of any other place to put it (post-command-hook maybe?).

[joaotavora]

so it would be interesting to enable highlighting without having to enable hover. eldoc-documentation-functions might not be the best place for this, though, but I can't think of any other place to put it (post-command-hook maybe?).

I think you need to provide, without reference to the functions or internals, an example where you describe exactly what happens today (in the server of your choice, with an example file of your choice) and what happens tomorrow when your dream change is implemented. I found it hard to follow your text, though I recognize some parts.

[bigodel]

Any thoughts on how to implement :documentHighlightProvider independent from :hoverProvider? It could likely be implemented in a way that could still be reused by eglot-hover-eldoc-function.

BTW why they are couple together? Seems odd given that they are two different textDocument capabilities.

[joaotavora]

They are coupled together to save on UI logic, hence the name "piggyback".

As far as I understand, your desired behavior as described earlier can be solved by bigodel/eldoc-thingy as suggested.

[bigodel]

As far as I understand, your desired behavior as described earlier can be solved by bigodel/eldoc-thingy as suggested.

Nope, it doesn't, since doing that will require a full hover when I only want :documentHighlightProvider. And your other proposal also doesn't work because I don't want to fully disable :hoverProvider, I only disable it when ElDoc is being presented in the echo area. I am requesting and willing to propose a patch that exposes :documentHighlightProvider as a feature for users independently to :hoverProvider.

[joaotavora]

You told me

even though eglot-hover-eldoc-function is not part of eldoc-documentation-functions I can still achieve highlighting of the symbol at point.

replace eglot-hover-eldoc-function with the functtion I gave you and you will have this. This is all the help I can give you.

[bigodel]

replace eglot-hover-eldoc-function with the functtion I gave you and you will have this.

I tried it, and that doesn't work consistently as some times (I can't pinpoint exactly when it happens) it'll bring up hover information to the echo area, which I'm trying to avoid. Besides, it triggers a full hover when all I want is to highlight the symbol at point...

This is all the help I can give you.

Can I take this as you don't think it would be beneficial to provide :documentHighlightProvider as a feature? Is there any particular reasoning besides saving a little bit of UI logic?