Can't click hyperlink to open in web browser in eldoc-doc-buffer

[488Ques]

I'm using the Gopls language server. I have this Golang code

err = os.MkdirAll(config.FilesDir, 0755)

Where I place the point on os.MkdirAll method and M-x eldoc-doc-buffer to see the full documentation

Then I click on the hyperlink os.MkdirAll on pkg.go.dev that links to the documentation website of that method, I expect the link to be opened in my web browser but instead only see the message user-error: Nothing to follow at point which is produced by markdown-follow-thing-at-point.

I'm not sure if this is intended behavior, a bug or an error on my end.

I made a temporary solution:

(defun eglot-open-link ()
  "Open markdown link at point in the `eldoc-doc-buffer'."
  (interactive)
  (let ((url (get-text-property (point) 'help-echo)))
    (if url
	(browse-url-xdg-open url)
      (message "No URL found at point"))))

[nafiz1001]

I'm getting a similar problem with rust-analyzer, except I get progn: Beginning of buffer as an error which is produced by the forward-char call in markdown-backward-to-link-start which is in markdown-link-p which is also in markdown-follow-thing-at-point.

I've also attempted on a temporary solution, but it doesn't work :(

[vkz]

Experiencing the exact same thing:

• eglot v1.16 from latest master via straight
• GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu) of 2024-04-02 - built from source tags/v29.2

Technically RET is bound to when on the pkg.go.dev link and that is bound to markdown-follow-thing-at-point as per hidden properties but it either reports Nothing to follow or markdown-link-p: Beginning of buffer depending on exactly where in that link the point is.

FWIW this is in terminal emacs launched on the remote machine over ssh. I half expect it'll work fine in GUI Emacs on local machine somehow but I haven't tried.

OP trick with extracting hidden url (get-text-property (point) 'help-echo) does work.

[ewollesen]

Same issue here:

• eglot 1.17
• GNU Emacs 29.3.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo
  version 1.18.0) of 2024-05-28

I wonder if #865 is somehow related? But the fix for that (PR #866) seems to have been included in eglot 1.17. There's also some mention of an issue on the eldoc side of things, so I'll look a bit at that, too.

[ParetoOptimalDev]

The issue seems to be that markdown-backward-to-link-start uses (skip-chars-backward "^[").

From an eldoc buffer where | denotes cursor position like:

encode :: forall a. ToJSON a => a -> ByteString

Defined in ‘Data.Aeson’ (aeson-2.1.2.1)

Efficiently serialize a JSON value as a lazy  L.ByteString . 

This is implemented in terms of the  ToJSON  class's  toEncoding  method.

Docum|entation <---- link

Source  <---- link

(skip-chars-backward "^[") from that position goes to the begining of the buffer and makes the next forward-char call return forward-char: Beginning of buffer.

So the links in the eldoc buffer aren't formatted as markdown-mode expects?