Skip to content

Commit cbd9f49

Browse files
josephangbcjoaopamaral
authored andcommitted
Use selectinload in trigger (apache#40487)
1 parent acfca73 commit cbd9f49

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

airflow/models/trigger.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from typing import TYPE_CHECKING, Any, Iterable
2222

2323
from sqlalchemy import Column, Integer, String, Text, delete, func, or_, select, update
24-
from sqlalchemy.orm import joinedload, relationship
24+
from sqlalchemy.orm import relationship, selectinload
2525
from sqlalchemy.sql.functions import coalesce
2626

2727
from airflow.api_internal.internal_api_call import internal_api_call
@@ -75,7 +75,7 @@ class Trigger(Base):
7575
uselist=False,
7676
)
7777

78-
task_instance = relationship("TaskInstance", back_populates="trigger", lazy="joined", uselist=False)
78+
task_instance = relationship("TaskInstance", back_populates="trigger", lazy="selectin", uselist=False)
7979

8080
def __init__(
8181
self,
@@ -152,7 +152,7 @@ def bulk_fetch(cls, ids: Iterable[int], session: Session = NEW_SESSION) -> dict[
152152
select(cls)
153153
.where(cls.id.in_(ids))
154154
.options(
155-
joinedload(cls.task_instance)
155+
selectinload(cls.task_instance)
156156
.joinedload(TaskInstance.trigger)
157157
.joinedload(Trigger.triggerer_job)
158158
)

docs/spelling_wordlist.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1443,6 +1443,7 @@ Seedlist
14431443
seedlist
14441444
seekable
14451445
segmentGranularity
1446+
selectin
14461447
Sendgrid
14471448
sendgrid
14481449
sentimentMax

0 commit comments

Comments
 (0)