From 9d62577fcf811dc4d4b1c1ece75a7e7b5a07948e Mon Sep 17 00:00:00 2001 From: Pierre Tessier Date: Fri, 19 Jan 2024 08:46:48 -0500 Subject: [PATCH] [currency] - fix metricreader export and temporality (#1335) * default metricreader and exporter options Signed-off-by: Pierre Tessier * default metricreader and exporter options Signed-off-by: Pierre Tessier --------- Signed-off-by: Pierre Tessier Co-authored-by: Juliano Costa --- CHANGELOG.md | 2 ++ src/currencyservice/src/meter_common.h | 7 +++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 68225966f2..c9180928f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,8 @@ release. ([#1291](https://github.com/open-telemetry/opentelemetry-demo/pull/1291)) * [currencyservice] - add package name prefix to `rpc.service` attribute ([#1333](https://github.com/open-telemetry/opentelemetry-demo/pull/1333)) +* [currency] fix metric exporter options + ([#1335](https://github.com/open-telemetry/opentelemetry-demo/pull/1335)) ## 1.7.2 diff --git a/src/currencyservice/src/meter_common.h b/src/currencyservice/src/meter_common.h index 6167e9edfb..61ae118994 100644 --- a/src/currencyservice/src/meter_common.h +++ b/src/currencyservice/src/meter_common.h @@ -24,15 +24,14 @@ namespace { // Build MetricExporter otlp_exporter::OtlpGrpcMetricExporterOptions otlpOptions; - // Configuration via environment variable not supported yet - otlpOptions.aggregation_temporality = otlp_exporter::PreferredAggregationTemporality::kDelta; + //otlpOptions.aggregation_temporality = otlp_exporter::PreferredAggregationTemporality::kCumulative; auto exporter = otlp_exporter::OtlpGrpcMetricExporterFactory::Create(otlpOptions); // Build MeterProvider and Reader metric_sdk::PeriodicExportingMetricReaderOptions options; - options.export_interval_millis = std::chrono::milliseconds(1000); - options.export_timeout_millis = std::chrono::milliseconds(500); + //options.export_interval_millis = std::chrono::milliseconds(60000); + //options.export_timeout_millis = std::chrono::milliseconds(30000); std::unique_ptr reader{ new metric_sdk::PeriodicExportingMetricReader(std::move(exporter), options) }; auto provider = std::shared_ptr(new metric_sdk::MeterProvider());