Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline offsets cannot be specified #4

Open
stefan-hudelmaier opened this issue Jun 30, 2020 · 1 comment
Open

Timeline offsets cannot be specified #4

stefan-hudelmaier opened this issue Jun 30, 2020 · 1 comment

Comments

@stefan-hudelmaier
Copy link

Hi,

Anime changed the way that timeline offsets are specified in v3. They are given as a second parameter to the add function. (see juliangarnier/anime@8338490)

In jm-react-anime add is always called with a single parameter. From quickly glancing at the Anime code I thought that using the option timelineOffset in the timeline steps should work as well, but it appears not to.

Changing

mode.map(anim => tl.add(anim));

to

mode.map(anim => tl.add(anim, anim.timelineOffset)); 

would get this working, but I'm not sure if this is something that you would want to do this way.

I could provide a PR with this solution or a different one that you prefer.

@jmdisuanco
Copy link
Owner

Hi,

Sorry for the late reply.

Your PR will be much appreciated.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants