Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test nav_test is failing #98

Open
myphysicslab opened this issue May 3, 2017 · 1 comment
Open

unit test nav_test is failing #98

myphysicslab opened this issue May 3, 2017 · 1 comment

Comments

@myphysicslab
Copy link

The unit test at test/js/nav_test.html fails when opening with Safari browser on Mac OS. The other two unit tests there, heap_test and search_test are succeeding. The error is

dossier.nav.test [FAILED]

12:04:50.352  Start
12:04:50.354  testBuildTree_attachesNestedClassesToParentNamespace : FAILED (run individually)
12:04:50.354  ERROR in testBuildTree_attachesNestedClassesToParentNamespace
Can't find variable: Arrays
> (unknown)
> (unknown)
> (unknown)
> (unknown)
> (unknown)
> testBuildTree_attachesNestedClassesToParentNamespace at file:///Users/erikn/Documents/Programming/js-dossier/test/js/nav_test.js:182:27
> (unknown)
> invokeTestFunction_ at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/testing/testcase.js:853:25
> safeRunTest_ at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/testing/testcase.js:803:27
> invokeTestFunction_ at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/testing/testcase.js:879:23
> runNextTest_ at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/testing/testcase.js:793:27
> (unknown)
> Promise at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/promise/promise.js:164:20
> runTestsReturningPromise at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/testing/testcase.js:757:26
> execute at file:///Users/erikn/Documents/Programming/js-dossier/third_party/js/closure_library/closure/goog/testing/testrunner.js:264:43
> (unknown)

If I substitute goog.array for Arrays in the file src/js/nav.js the test proceeds past that error, but some similar errors occur on other names. With similar substitutions, the test succeeds. Specifically these substitutions:

Arrays --> goog.array
Index --> proto.dossier.Index
NamedType --> proto.dossier.expression.NamedType

Does the deps.js file need to be regenerated? Or is there some missing magic about using goog.module and goog.require?

@myphysicslab
Copy link
Author

Now that closure-library is no longer in the repository because of commit f0e495c, all of these unit tests at test/js/ are no longer working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant