-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/fix Leiningen usage #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Look good.
CI tests are failing, but that's related to the latest graalvm update on nixpkgs, nothing to do this your PR.
I want to run a couple of tests before merging
@@ -73,6 +73,7 @@ in | |||
inherit (cfg) projectSrc name version main-ns buildCommand | |||
lockfile java-opts compileCljOpts javacOpts | |||
builder-extra-inputs builder-java-opts builder-preBuild builder-postBuild; | |||
enableLeiningen = cfg.withLeiningen; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 that was the idea, thanks!
Yeah this currently isn't tested well. I'm also throwing it at my use case right now. Edit: The |
@JohnnyJayJay I'm not familiar with Leiningen, I didn't test the |
I definitely want to investigate further. Something very strange is happening with the |
Aha, I found the issue – the |
It's good to be merged from my side now. |
Thanks! |
This PR changes/fixes 3 small things that improve the usage of clj-nix for Leiningen users:
withLeiningen
module option (closes Unsatisfiable condition for optionwithLeiningen
#144 )withLeiningen
to the derivation asenableLeiningen
(so the option actually does something)--lein-profiles
to the deps-lock CLI that allows one to set the profile(s) to use when generating the lock file. This is useful to have because currently, all custom profiles are merged (which can result in unwanted configuration outcomes that break the build, e.g. due to:repositories
or:offline?
options).