Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When remastering a golden, moves at the beginning or end should modify the game timestamps #766

Open
jkomoros opened this issue Jul 28, 2020 · 0 comments

Comments

@jkomoros
Copy link
Owner

Originally captured in #701

If new moves are in the middle, we evenly split the timestamps between existing moves in the golden. But if the new moves are at the beginning or end of the game, we simply copy the beginning/end time. That's not ideal because it means that you'll have timestamps that appear to be at the same literal time instead of monotonically increasing.

Ideally we'd extend the timestamps based on how far they differ from their next moves in the new record. When we extend the start of the game and end, we'd need to modify all subsequent time stamps, and possibly also save a new Game.Modified timestamp to match the new final timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant