Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have game variants be handled entirely in the server layer, not the core library #753

Open
jkomoros opened this issue Apr 4, 2020 · 0 comments

Comments

@jkomoros
Copy link
Owner

jkomoros commented Apr 4, 2020

Discovered while pulling on #752, player group selection.

The core engine has a lot of logic exposed about variants, because they have to be decided before the actual game is set up.

But if we have player/team selection and validation within the custom game logic (as far as the core engine is concerned) then we should have variant logic in the same layer, because you might want to run it at the same time as player selection, or after, or before.

That would allow us to get rid of lots of Variants logic and put them in a sub library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant