Revert CMake version bump, but instead add header files into INTERFACE projects if version >= 3.19

jk-jeon · jk-jeon · commit 0f8eb32c642d · 2024-08-28T16:42:29.000-07:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(dragonbox
         VERSION 1.1.3
@@ -21,7 +21,11 @@ endif()
 
 set(dragonbox_headers include/dragonbox/dragonbox.h)
 
-add_library(dragonbox INTERFACE ${dragonbox_headers})
+if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.19.0")
+	add_library(dragonbox INTERFACE ${dragonbox_headers})
+else()
+	add_library(dragonbox INTERFACE)
+endif()	
 add_library(dragonbox::dragonbox ALIAS dragonbox)
 
 target_include_directories(dragonbox
@@ -33,7 +37,13 @@ target_compile_features(dragonbox INTERFACE cxx_std_17)
 
 # ---- Declare library (dragonbox_to_chars) ----
 
-set(dragonbox_to_chars_headers include/dragonbox/dragonbox_to_chars.h)
+if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.19.0")
+	set(dragonbox_to_chars_headers include/dragonbox/dragonbox_to_chars.h)
+else()
+	set(dragonbox_to_chars_headers
+        	${dragonbox_headers}
+        	include/dragonbox/dragonbox_to_chars.h)
+endif()
 
 set(dragonbox_to_chars_sources source/dragonbox_to_chars.cpp)
 
diff --git a/subproject/3rdparty/grisu_exact/CMakeLists.txt b/subproject/3rdparty/grisu_exact/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(grisu_exact LANGUAGES CXX)
 
diff --git a/subproject/3rdparty/ryu/CMakeLists.txt b/subproject/3rdparty/ryu/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(ryu_cmake LANGUAGES C)
 
diff --git a/subproject/3rdparty/schubfach/CMakeLists.txt b/subproject/3rdparty/schubfach/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(schubfach LANGUAGES CXX)
 
diff --git a/subproject/benchmark/CMakeLists.txt b/subproject/benchmark/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(benchmark LANGUAGES CXX)
 
diff --git a/subproject/common/CMakeLists.txt b/subproject/common/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(dragonbox_common LANGUAGES CXX)
 
diff --git a/subproject/meta/CMakeLists.txt b/subproject/meta/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(dragonbox_meta LANGUAGES CXX)
 
diff --git a/subproject/simple/CMakeLists.txt b/subproject/simple/CMakeLists.txt
@@ -1,10 +1,14 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(dragonbox_simple LANGUAGES CXX)
 
 set(dragonbox_simple_headers include/simple_dragonbox.h)
 
-add_library(dragonbox_simple INTERFACE ${dragonbox_simple_headers})
+if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.19.0")
+	add_library(dragonbox_simple INTERFACE ${dragonbox_simple_headers})
+else()
+	add_library(dragonbox_simple INTERFACE)
+endif()
 add_library(dragonbox::simple ALIAS dragonbox_simple)
 
 target_include_directories(dragonbox_simple
diff --git a/subproject/test/CMakeLists.txt b/subproject/test/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(dragonboxTests LANGUAGES CXX)
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-cmake_minimum_required(VERSION 3.19 FATAL_ERROR)`
	`1`	`+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)`
`2`	`2`
`3`	`3`	`project(grisu_exact LANGUAGES CXX)`
`4`	`4`