Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DTMF UI controls #6332

Closed
jbguerraz opened this issue Apr 23, 2020 · 17 comments
Closed

Add DTMF UI controls #6332

jbguerraz opened this issue Apr 23, 2020 · 17 comments
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement

Comments

@jbguerraz
Copy link

jbguerraz commented Apr 23, 2020 •
edited
Loading

Exactly the same as #3606

When adding a SIP caller through jigasi it would be nice to have the option to send DTMF tones.
For example I would like to be able to dial into a third party PSTN conference bridge and currently can't do that because I can't send the required PIN.
It looks like this functionality did exist at some point but then was removed #2731

What's the status with DTMF ? Is there a chance to get it somehow ? Is there a need for contribution ?

Thank you!
@Echolon Echolon added the feature-request Issue which suggest an idea, enhancement or feature to implement label May 17, 2020
@stale
Copy link

stale bot commented Aug 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Aug 15, 2020
@jbguerraz
Copy link
Author

not stale ;) I'd be happy to know!

@stale stale bot removed the wontfix Issue won't be fixed label Aug 17, 2020
@damencho
Copy link
Member

Yes this was removed and is not used through the UI

@jbguerraz
Copy link
Author

Hello @damencho
Would you accept some contribution that bring it back ? We'd love to bridge another conference using PSTN.

@damencho
Copy link
Member

Yep, that sounds ok. Just need to be behind flag disabled by default.
Thank you.

@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Nov 21, 2020
@jbguerraz
Copy link
Author

This is still something we want to tackle at some point (probably S2 2021)

@stale stale bot removed the wontfix Issue won't be fixed label Nov 21, 2020
@cbeckr
Copy link

cbeckr commented Mar 3, 2021

Once you have the UI in place, note that there are still some issues with the DTMF translation back into SIP calls. I submitted a pull request at jitsi/libjitsi#433.

@mwllgr
Copy link

mwllgr commented Mar 25, 2021

+1 for this. I'd need the DTMF controls too.

@cbeckr cbeckr mentioned this issue Mar 26, 2021
Closed
@cbeckr
Copy link

cbeckr commented Mar 26, 2021

See PR above: #8890

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Jul 21, 2021
@cbeckr
Copy link

cbeckr commented Jul 21, 2021

I'll try to follow up here over the next week or so.

@stale stale bot removed the wontfix Issue won't be fixed label Jul 21, 2021
@mwllgr
Copy link

mwllgr commented Nov 16, 2021

Any news on the PR @cbeckr?

@cbeckr
Copy link

cbeckr commented Nov 16, 2021

Sorry @mwllgr, unfortunately I won't have time to work on this in the foreseeable future due to other commitments. If anyone else could finish the PR I'd appreciate it.

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Apr 18, 2022
@jbguerraz
Copy link
Author

up

@stale stale bot removed the wontfix Issue won't be fixed label Apr 19, 2022
@saghul
Copy link
Member

saghul commented Apr 25, 2022

I'm going to close this since we have no plans to add such a feature at this time, sorry.

@saghul saghul closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Issue which suggest an idea, enhancement or feature to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@saghul @jbguerraz @cbeckr @damencho @mwllgr @Echolon