-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various accessibility issues in the React Native code #5817
Comments
I just realized that my point 2 above is better solved with the second approach, AKA keeping the label intact and adding the selected state when appropriate, as to keep it in sync with the web version which just adds aria-pressed, making them into toggle buttons. Unfortunately I don't currently have the ability to build react-native stuff, much less test on a device (the simulators are inaccessible to me as a screen reader user). So while I can give pointers to where in code this needs to happen, theoretically, I have no way of knowing whether the code I'd put in there would actually compile. React confuses me with what goes in parentheses when and when not etc. |
You are free to review #5825 at your discretion. It is not completed yet, but the stuff that is there should, in theory, make things a lot better already for both iOS and Android. Also, pointers to especially the big area outside the bottom sheet that can be clicked to dismiss that bottom sheet, are appreciated. Or you take over and complete that with a corresponding accessibilityLabel, and accessibilityRole ‚button‘. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
The React Native code of the Jitsi Meet iOS and Android client has various accessibility issues. The Accessibility API for React Native is documented here.
accessibilityRole = 'button'
property.Current behavior
Many items do not have semantic meaning when used with VoiceOver on iOS or TalkBack on Android.
Expected Behavior
Items should have meaning and proper representation of current state.
Possible Solution
See inline in the list above.
Steps to reproduce
Environment details
Current app store version of Jitsi Meet, on current iPhone or iPad.
CC @damencho @t3chguy
The text was updated successfully, but these errors were encountered: