Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverflowMenuItem.web.js is not accessible #5681

Open
t3chguy opened this issue Apr 5, 2020 · 6 comments
Open

OverflowMenuItem.web.js is not accessible #5681

t3chguy opened this issue Apr 5, 2020 · 6 comments
Labels
accessibility Issue related to accessibility topics/handicapped users confirmed Confirmed bug, should not go stale web Issue related to the web frontend

Comments

@t3chguy
Copy link
Contributor

t3chguy commented Apr 5, 2020

Description

As of #5432 the bottom toolbar is now accessible, the "overflow" menu however is not.

Current behavior

Some buttons within the overflow, namely,

  • Start live stream
  • Blur my background
  • Settings
  • Mute everyone

are fine and accessible as they inherit from AbstractButton, but OverflowMenuItem (which is used for seemingly the remainder of the overflow menu options) does not.

Expected Behavior

Keyboard accessibility of all buttons.

Possible Solution

Switch to using <button> instead of <li> or copy all the tabIndex, onKeyDown, onKeyUp handlers from ToolboxItem.web.js or use something which extends AbstractButton.

I would like to help here, but am struggling to grok the code layout and patterns here with it being react-native-able.

@MarcoZehe
Copy link
Contributor

Yes, I can confirm this.

@MarcoZehe
Copy link
Contributor

@damencho Do you have any pointers to @t3chguy 's question above?

@damencho
Copy link
Member

damencho commented Apr 8, 2020

I need to ask for help, @hristoterezov, @paweldomas @zbettenbuk Can you help, please?

@paweldomas
Copy link
Member

@damencho I will try to help, but right now I'm doing it in my free time, so not sure when will I get to it

@Echolon
Copy link

Echolon commented May 13, 2020

Hi,
The team is aware of accessibility. Any reports are now grouped in the pinned issue #6090 and #3590.

I'm a community contributor and not directly affiliated with the Jitsi team.

@Echolon Echolon closed this as completed May 13, 2020
@l3d00m l3d00m reopened this May 16, 2020
@l3d00m l3d00m added the accessibility Issue related to accessibility topics/handicapped users label May 16, 2020
@luixxiul luixxiul added the web Issue related to the web frontend label May 16, 2020
@stale
Copy link

stale bot commented Aug 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Aug 15, 2020
@Echolon Echolon added confirmed Confirmed bug, should not go stale and removed wontfix Issue won't be fixed labels Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility topics/handicapped users confirmed Confirmed bug, should not go stale web Issue related to the web frontend
Projects
None yet
Development

No branches or pull requests

7 participants