-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OverflowMenuItem.web.js is not accessible #5681
Labels
accessibility
Issue related to accessibility topics/handicapped users
confirmed
Confirmed bug, should not go stale
web
Issue related to the web frontend
Comments
Yes, I can confirm this. |
I need to ask for help, @hristoterezov, @paweldomas @zbettenbuk Can you help, please? |
@damencho I will try to help, but right now I'm doing it in my free time, so not sure when will I get to it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
Issue related to accessibility topics/handicapped users
confirmed
Confirmed bug, should not go stale
web
Issue related to the web frontend
Description
As of #5432 the bottom toolbar is now accessible, the "overflow" menu however is not.
Current behavior
Some buttons within the overflow, namely,
are fine and accessible as they inherit from AbstractButton, but OverflowMenuItem (which is used for seemingly the remainder of the overflow menu options) does not.
Expected Behavior
Keyboard accessibility of all buttons.
Possible Solution
Switch to using
<button>
instead of<li>
or copy all thetabIndex, onKeyDown, onKeyUp
handlers fromToolboxItem.web.js
or use something which extendsAbstractButton
.I would like to help here, but am struggling to grok the code layout and patterns here with it being react-native-able.
The text was updated successfully, but these errors were encountered: