From 92d3605cbd98b423087fe954fdb71b7a6ad4b88f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 12 Jul 2026 02:55:07 +0000 Subject: [PATCH 1/3] Bump the nuget group with 3 updates Bumps Microsoft.SourceLink.GitHub from 8.0.0 to 10.0.300 Bumps ReverseMarkdown from 5.4.0 to 6.1.0 Bumps Terminal.Gui from 2.4.16 to 2.4.17 --- updated-dependencies: - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.300 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget - dependency-name: ReverseMarkdown dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget - dependency-name: Terminal.Gui dependency-version: 2.4.17 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget ... Signed-off-by: dependabot[bot] --- Directory.Packages.props | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index a8018c3..1bdb281 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -10,9 +10,9 @@ - - - + + + From 17d1d5272023c0bfd12cf6124f4cb2618c99f0a8 Mon Sep 17 00:00:00 2001 From: Justin Puah Date: Sun, 19 Jul 2026 00:21:30 +1000 Subject: [PATCH 2/3] fix(text): migrate to ReverseMarkdown 6 Config API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit v6 moved UnknownTags/RemoveComments onto nested Tags/Formatting option objects (the flat properties are now [Obsolete] → build errors under TreatWarningsAsErrors). Behaviour-preserving; HtmlMarkdown tests unchanged and green. --- src/Cobalt.Core/Text/HtmlMarkdown.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Cobalt.Core/Text/HtmlMarkdown.cs b/src/Cobalt.Core/Text/HtmlMarkdown.cs index 806a752..35078fe 100644 --- a/src/Cobalt.Core/Text/HtmlMarkdown.cs +++ b/src/Cobalt.Core/Text/HtmlMarkdown.cs @@ -14,9 +14,11 @@ public static partial class HtmlMarkdown { private static readonly ReverseMarkdown.Converter ToMd = new(new ReverseMarkdown.Config { - UnknownTags = ReverseMarkdown.Config.UnknownTagsOption.PassThrough, + // ReverseMarkdown 6 moved these onto nested option objects (the old flat + // UnknownTags/RemoveComments are [Obsolete]); GithubFlavored stayed top-level. + Tags = { Unknown = ReverseMarkdown.Config.UnknownTagsOption.PassThrough }, GithubFlavored = true, - RemoveComments = true, + Formatting = { RemoveComments = true }, }); private static readonly MarkdownPipeline MdPipeline = From 19414e1f896aa789a970be2ad3321c7800cb89d1 Mon Sep 17 00:00:00 2001 From: Justin Puah Date: Sun, 19 Jul 2026 00:28:06 +1000 Subject: [PATCH 3/3] test(text): pin comment-strip + unknown-tag passthrough across the RM6 migration --- tests/Cobalt.Core.Tests/Text/HtmlMarkdownTests.cs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/Cobalt.Core.Tests/Text/HtmlMarkdownTests.cs b/tests/Cobalt.Core.Tests/Text/HtmlMarkdownTests.cs index bf72045..fc7bdc2 100644 --- a/tests/Cobalt.Core.Tests/Text/HtmlMarkdownTests.cs +++ b/tests/Cobalt.Core.Tests/Text/HtmlMarkdownTests.cs @@ -28,6 +28,18 @@ public void Empty_And_Null_Html_Become_Empty_Markdown() Assert.Equal("", HtmlMarkdown.ToMarkdown("")); } + [Fact] + public void Html_To_Markdown_Strips_Comments_And_Passes_Unknown_Tags_Through() + { + // Pins the two options carried across the ReverseMarkdown 6 config API migration: + // Formatting.RemoveComments strips HTML comments, and Tags.Unknown = PassThrough keeps an + // unsupported tag verbatim (so a lossy round-trip stays visible) rather than dropping it. + var md = HtmlMarkdown.ToMarkdown("

keep this

inner text"); + + Assert.DoesNotContain("drop me", md); // RemoveComments strips the comment + Assert.Contains("inner text", md); // PassThrough keeps the unknown tag as-is + } + [Fact] public void Simple_Content_Round_Trips_Cleanly() {